Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

Compiler Plugin: Plan to add compiler for MSys2

<< < (5/6) > >>

stahta01:
Decided to add a second checked box named something like "Do not show disabled Compilers" to add the feature you want.

Will use new name for the method I edited called something like "conditionalRegisterCompiler".
And, move the reading of the GUI setting inside it.

So, my patch will need to be changed a lot.

I will be working on the GUI changes and then do the code changes.

Edit: For some unknown reason the "GNU GCC Compiler for ARM" is still being displayed in the list.
I would guess it has a broken IsValid method.

Tim S.

stahta01:
Attached patch that still needs work.

It is missing any GUI button to disable a Compiler. That is the next thing for me to add.
Button called "Disable"? I will look back at your posts to see where you wanted the button.

And, it has commented out code in it.

Please verify my changes to compiler.h file?
And, I edited compiler_options.xrc directly, is there an wxSmith file I should edit instead?

Tim S.

stahta01:

--- Quote from: oBFusCATed on October 24, 2016, 12:23:22 am ---It should be in a new dialog hidden behind an Add button in just below the selected compiler combo box we have now.

--- End quote ---

Adding a Dialog is beyond what I feel up to doing at this time; but, it does make more sense than an "Disable" button like I was thinking of doing.

I am a C Programming who does almost no GUI programming.

I will see if any of the wx Dialogs I know about can be adapted to do what you want; but, I will NOT have time for a few weeks.

Tim S.

stahta01:

--- Quote from: stahta01 on October 24, 2016, 06:16:14 pm ---
--- Quote from: oBFusCATed on October 24, 2016, 12:23:22 am ---It should be in a new dialog hidden behind an Add button in just below the selected compiler combo box we have now.

--- End quote ---

Adding a Dialog is beyond what I feel up to doing at this time; but, it does make more sense than an "Disable" button like I was thinking of doing.

I am a C Programming who does almost no GUI programming.

I will see if any of the wx Dialogs I know about can be adapted to do what you want; but, I will NOT have time for a few weeks.

Tim S.

--- End quote ---

Would it look OK if I moved the "selected compiler combo box" a little to the right and have the button to the left of it?
I think the dialog will be used to "adjust the compilers listed" for the hint; no idea about the button name.

I will have to look at the code behind the  "selected compiler combo box" and do research on wx combo boxes.

Tim S.

oBFusCATed:
I don't like the idea of the checkboxes at all as already mentioned.

About default parameters - just make it non-default and pass the correct value at every call site. There is no need for a separate function.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version