Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

bug in configmanager.cpp and patch file

(1/1)

frithjofh:
hi everybody,

found a bug in configmanager.cpp which can lead to undefined behaviour. probably harmless...

but patch attached.

function used map.erase(iterator) and then tries to increment that iterator in the next loop and use it again. this is undefined according to both wx documentation and stl documentation.

replaced call to map.erase(iter) inside the loop with call to clear map.clear() after the loop

regards

frithjofh:
patch has an error

attached the correct one

oBFusCATed:
This will probably cause a crash someday. Will apply it next week, when I get access to my computer back.

ollydbg:
The patch is in trunk now, thanks.

Navigation

[0] Message Index