Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

ToDo plugin patch doing some refactoring

<< < (4/6) > >>

frithjofh:
ok, thx,

I will take another look at the changes I made. not sure if I will have time before Xmas though.

frithjofh:
@morten

I looked through my implementation of wxwidgets and there the subscript is implemented just like that too...

It has a the same body as GetChar(), that is, just a call to at()... essentially the same it seems.

I only looked in wxGTK, the current 2.8 stable, so maybe there is some difference with the implementation you checked.

I am a bit confused now...

frithjofh:
just to revive this thread

current situation is the question whether GetChar() and subscript are essentially the same, as both are implemented using at()

MortenMacFly:

--- Quote from: frithjofh on January 17, 2016, 03:29:27 pm ---current situation is the question whether GetChar() and subscript are essentially the same, as both are implemented using at()

--- End quote ---
In that case it seems the same. But you cannot always rely on it. IMHO (at least in earlier versions) in STL its not.

As a rule of thumb: To make it bullet-proof don't use [] unless you're 100% sure you are doing the right thing and/or care for speed.

frithjofh:
so, should I edit the patch accordingly or leave it as is?

Navigation

[0] Message Index

[#] Next page

[*] Previous page