Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

CodeCompletion Close project anomally

<< < (3/3)

ollydbg:

--- Quote from: Pecan on November 13, 2015, 06:32:23 pm ---ollydbg,

I'd like to propose a patch to parser.h/cpp that records the internal threads (just like cbthreadpool) and posts Abort() to the internal threads when ~parser is invoked.

Initial testing with the patch shows that closing a large project (like CodeBlocks.cbp) terminates very fast (without the long delay previously experienced).

If you agree/modify the patch, we can later clean it up (removing //(pecan 2015/11/13) tags which I use to find mods fast) and apply.

I also include one line patches to the logger code to avoid crashes I've experienced a few times when closing CB while CC was busy.

svn build  rev 10554 (2015-11-01 09:18:34)   gcc 4.9.2 Windows/unicode - 32 bit

--- End quote ---
Great work, I see you use quite a smart idea to solve this issue. The patch is OK to commit from my side.
Here is what I suggest:
1, I think handling #include is just like a "push" and "pop" file stack. When see a #include directive, a new ParserThread is created, it is pushed to the stack, and leave a header file will pop the ParserThread from the stack, so some code can be simplified(no need to loop on the full list elements). In the future the stack can used to generate all the file dependency.
2, I would suggest adding some doxygen style document before the function prototype.

Pecan:

Patch (with minor changes) applied SVN 10571.

Thanks everyone, especially ollydbg for the time spent guiding me through CodeCompletion.

lane

Navigation

[0] Message Index

[*] Previous page