User forums > General (but related to Code::Blocks)

Some suggestions for C::B improvements

<< < (5/5)

kevinxy:
Fair enough.

I reenabled 'repeated chars'.

I added 4 or 5 additional unit tests.

Can someone test it just to confirm that I have set up everything correctly?

Also, a live test on some other version of GDB would be great.

Here is the patch.

oBFusCATed:
Ok, passes all tests.

But I'm a bit concerned that you've special cased this just for std::vector.
If I remember correctly the old logic was a bit more generic.
I'll have to test if the parser still works for my custom containers.

kevinxy:
Well, why not?

note: the only important change and a 'special case' is the change of delimiters so that the string ", cap" is not cosidered to be a comma anymore.

The rest of the changes are either cosmetic, or removal of some complex cases and questionalbe flow control which seemed to me as completely unnecessary.

In fact, I was quite conservative, if I had more confidence, I would have removed about half the code. But before I do that I need at least to set up my development environment correctly, this ad-hoc setup that I glued together is quite frustrating.

oBFusCATed:
Probably, I've not written tests for my custom containers. So if they use something different from ", capacity", they'll brake with the new changes.
But I'll be able to do the tests on Monday.

If you can remove half the code and still make the tests pass then I'm with it.
But every line of code is added because there is need for it, so I highly doubt you'll be able to do it.

BTW: I've attached a bit cleaner version of your code, more cleaning is needed to make it in a good shape for commit.

kevinxy:
Thanks for cleaning it up!

By the way, it will not completely break up if there is no ", capacity" string, it will just add some extra unwanted children. Actually, it will only do that when there is a non item-separating comma not followed by " cap".

Navigation

[0] Message Index

[*] Previous page