Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Windows XP manifests

(1/1)

sethjackson:
Hi I was looking at the manifest creation code, and since this is MSW only I added a *gasps* macro :lol: that lets it compile only on MSW (I hope I did it right). Is this OK? I'm going to submit a patch to SF.net if so.....

thomas:
Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

sethjackson:

--- Quote from: thomas on January 20, 2006, 09:09:06 am ---Not sure what was intended with that patch, but you put and #ifndef/#error block inside an #ifdef block, so #error inside #ifndef will never be seen.

But hey, no problem, the big #ifdef block is not necessary, I'll just copy the #ifndef block to the header, that'll do just fine and will work the way you intended.
No need to post to SF. :)

--- End quote ---

Ok I'm not to good with preprocessor macros (I looked at wx sources).....

Navigation

[0] Message Index