Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
Clang CC
oBFusCATed:
--- Quote from: yvesdm3000 on March 07, 2017, 02:15:09 pm ---Normally I try to keep these wxString objects created&destroyed on the same thread or deep-copied if they need to be handed over from one thread to another. It's probably better if I switch to std::string for anything that crosses these threads and force c++11 to assure thread-safety.
--- End quote ---
How are you doing the deep-copies? I'm thinking of adding something like cbDeepCopyWxString that is reliable for both wx2.8 and wx3.0.
Also switching to std::string is not really a good idea - you'll do many conversions and possibly loose unicode support (you'll have to use wstring for that).
BlueHazzard:
--- Quote from: yvesdm3000 on March 07, 2017, 03:52:23 pm ---
--- Quote from: BlueHazzard on March 07, 2017, 03:30:07 pm ---A other problem i noted quite frequently is if you open a new cpp file, enter code at the end of the file (no line text after the last line code) and this code has errors, so they get reported by the instant error reporting wxScilite will report some error about writing past the buffer, or writing non printable characters or something like this. I am actively investigating in this if i find some time.
This is no crash, but a assert()
I don't recall how i can reproduce this, but i will report as soon i am able to reproduce it...
--- End quote ---
Sounds familiar, I fixed something similar in the past, but it was only reproducible on Windows. Sadly I don't test it often on Windows. It's hard enough as it is to test on wx28, wx30, ubuntu, centos, ...
Yves
--- End quote ---
This seems to fix the error:
--- Code: ---diff --git a/src/clangrefactoring.cpp b/src/clangrefactoring.cpp
index b3913ac..f88b76d 100644
--- a/src/clangrefactoring.cpp
+++ b/src/clangrefactoring.cpp
@@ -217,8 +217,8 @@ void ClangRefactoring::BeginHighlightOccurrences(cbEditor* ed)
// Set Styling:
// clear all style indications set in a previous run (is also done once after text gets unselected)
stc->IndicatorClearRange(0, stc->GetLength());
-
- if (stc->GetTextRange(pos - 1, pos + 1).Strip().IsEmpty())
+ int max_length = std::min(pos + 1 ,stc->GetLength());
+ if (stc->GetTextRange(pos - 1, max_length).Strip().IsEmpty())
return;
const int line = stc->LineFromPosition(pos);
--- End code ---
i honestly don't know if it changes the behavior of the function, but at least it does not give this annoying message ;) . The decision if this is the right fix i let for the developer...
yvesdm3000:
--- Quote from: oBFusCATed on March 07, 2017, 09:54:06 pm ---
--- Quote from: yvesdm3000 on March 07, 2017, 02:15:09 pm ---Normally I try to keep these wxString objects created&destroyed on the same thread or deep-copied if they need to be handed over from one thread to another. It's probably better if I switch to std::string for anything that crosses these threads and force c++11 to assure thread-safety.
--- End quote ---
How are you doing the deep-copies? I'm thinking of adding something like cbDeepCopyWxString that is reliable for both wx2.8 and wx3.0.
Also switching to std::string is not really a good idea - you'll do many conversions and possibly loose unicode support (you'll have to use wstring for that).
--- End quote ---
I do a c_str() on the source wxString when the operation or event is copied. I also avoided using wxCommandEvent and built a ClangEvent object that does this deep copy of every member.
Yves
yvesdm3000:
--- Quote from: BlueHazzard on March 07, 2017, 11:58:19 pm ---
--- Quote from: yvesdm3000 on March 07, 2017, 03:52:23 pm ---
--- Quote from: BlueHazzard on March 07, 2017, 03:30:07 pm ---A other problem i noted quite frequently is if you open a new cpp file, enter code at the end of the file (no line text after the last line code) and this code has errors, so they get reported by the instant error reporting wxScilite will report some error about writing past the buffer, or writing non printable characters or something like this. I am actively investigating in this if i find some time.
This is no crash, but a assert()
I don't recall how i can reproduce this, but i will report as soon i am able to reproduce it...
--- End quote ---
Sounds familiar, I fixed something similar in the past, but it was only reproducible on Windows. Sadly I don't test it often on Windows. It's hard enough as it is to test on wx28, wx30, ubuntu, centos, ...
Yves
--- End quote ---
This seems to fix the error:
--- Code: ---diff --git a/src/clangrefactoring.cpp b/src/clangrefactoring.cpp
index b3913ac..f88b76d 100644
--- a/src/clangrefactoring.cpp
+++ b/src/clangrefactoring.cpp
@@ -217,8 +217,8 @@ void ClangRefactoring::BeginHighlightOccurrences(cbEditor* ed)
// Set Styling:
// clear all style indications set in a previous run (is also done once after text gets unselected)
stc->IndicatorClearRange(0, stc->GetLength());
-
- if (stc->GetTextRange(pos - 1, pos + 1).Strip().IsEmpty())
+ int max_length = std::min(pos + 1 ,stc->GetLength());
+ if (stc->GetTextRange(pos - 1, max_length).Strip().IsEmpty())
return;
const int line = stc->LineFromPosition(pos);
--- End code ---
i honestly don't know if it changes the behavior of the function, but at least it does not give this annoying message ;) . The decision if this is the right fix i let for the developer...
--- End quote ---
I applied the fix. Thanks !
Yves
yvesdm3000:
--- Quote from: oBFusCATed on March 07, 2017, 09:54:06 pm ---
--- Quote from: yvesdm3000 on March 07, 2017, 02:15:09 pm ---Normally I try to keep these wxString objects created&destroyed on the same thread or deep-copied if they need to be handed over from one thread to another. It's probably better if I switch to std::string for anything that crosses these threads and force c++11 to assure thread-safety.
--- End quote ---
How are you doing the deep-copies? I'm thinking of adding something like cbDeepCopyWxString that is reliable for both wx2.8 and wx3.0.
Also switching to std::string is not really a good idea - you'll do many conversions and possibly loose unicode support (you'll have to use wstring for that).
--- End quote ---
I want to use std::string because Clang uses utf8, otherwise i'm stuck with a conversion of 16 bits into 8 bits (for most of the cases). I know std::string isn't ideal for utf8 but when you know the limitations, it's doable since I don't process the strings all that much.
Yves
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version