Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
Clang CC
yvesdm3000:
--- Quote from: Alpha on November 03, 2015, 01:37:47 am ---
--- Quote from: scarphin on November 02, 2015, 02:38:23 pm ---Oh, one more thing I forgot about. I had to add:
--- Code: ---#include <iostream>
--- End code ---
to 'clangplugin.cpp' and 'translationunit.cpp' to build the plugin. I don't know why iostream were missing in those 2 files initially.
--- End quote ---
Erm... why do we need iostream? Logging/debug logging should be directed through C::B's log manager.
--- Quote from: yvesdm3000 on November 02, 2015, 09:06:06 pm ---
--- Quote from: scarphin on November 02, 2015, 01:32:44 pm ---What do you think? I'll submit patches using the name 'Clang Code Completion' under color settings in 'settings->environment->colors'.
--- End quote ---
No problem for me as long as Alpha0010 and the other nice C::B guys approve.
--- End quote ---
I believe the main CC plugin already registers some colors; if possible, reuse those first.
--- End quote ---
For the logging it's just debugging stuff, especially with threads I tend to be carefull and a simple fprintf is often easy. Those should be removed at a later stage in a cleanup when everything works as expected. Intended logging should go to the log manager.
For the colours, all I have seen is that the plugin simply returns the codecompletion data back to C::B so colouring should be handled on that level, except for maybe the HTML it returns for documentation.
Yves
scarphin:
--- Quote from: Alpha on November 03, 2015, 01:37:47 am ---Erm... why do we need iostream? Logging/debug logging should be directed through C::B's log manager.
--- End quote ---
I had to include them because the compiler were spitting 'cout doesn't belong to namespace std' kind of errors. I think yvesdm3000 made it clear.
--- Quote from: Alpha on November 03, 2015, 01:37:47 am ---I believe the main CC plugin already registers some colors; if possible, reuse those first.
--- End quote ---
As you wish. I also prefer to reuse the same colors but my reasoning was that the clang cc uses a different color for errors while the built-in cc doesn't have a designated color for that which might introduce color entries that are not used by some plugins. Also people may opt for different syntax highlighting for different languages making cc plugins for different languages less responsive in terms of colors. I think at least cc plugins for different languages should define their own colors.
@obfuscated: Stated above.
oBFusCATed:
--- Quote from: scarphin on November 03, 2015, 11:51:05 am ---Also people may opt for different syntax highlighting for different languages making cc plugins for different languages less responsive in terms of colors. I think at least cc plugins for different languages should define their own colors.
--- End quote ---
If you ask me this is not a good idea.
Generally I try to make all languages look roughly the same.
What error color are we talking about, because I've not tried this plugin yet?
scarphin:
I try to make all languages look exactly the same but that doesn't rule out other combinations users may provide.
As for the errors I provided 2 screenshots in one of my previous posts.
oBFusCATed:
I guess I've misunderstood you, because I thought that you're talking about some colours for errors. Ignore.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version