Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
Clang CC
yvesdm3000:
Hi MortenMacFly,
I committed your proposed fix on master. Looks like this was only overlooked in clangdiagnostics.cpp, the other places has the "RemoveAllEventSinksFor(this);".
Many thanks for pointing this out!
Yves
MortenMacFly:
--- Quote from: yvesdm3000 on January 24, 2016, 08:06:54 pm ---I committed your proposed fix on master. Looks like this was only overlooked in clangdiagnostics.cpp, the other places has the "RemoveAllEventSinksFor(this);".
--- End quote ---
OK, thank you. BTW: There are many more crash candidates. Unfortunately if you use this plugin on Windows it will definitely crash sooner or later. I've never been able to run a complete C::B session w/o crash. :-/
Another thing: Please don't use code that is not portable. alloca for example is very bad and should never be used. Also, currently your git HEAD is broken because it seems you did commit a file (tokendatabase.cpp) w/o resolving conflicts first.
If possible, I would recommend that you test this plugin from time to time on Windows. Be careful with hacks, they usually don't work on other platforms. If it compiles on Windows, I can help with that from time to time... just guide me what to do.
MortenMacFly:
Here comes another reproducible crash:
* have Clang plugin enabled
* disable the plugin in plugin manager
* search in files so that the result (listlog) has some entries
* try to open a file from the log (double-click)
-> Crash
yvesdm3000:
OK thank you for the bug report, I'll look into it as soon as I have some time for it.
I mostly test the plugin using my day-to-day work which is Linux-based ...
Maybe I should have some sessions on windows just so that I can try things, or have some unit-tests to run, it would certainly improve reliablity...
Yves
yvesdm3000:
I was able to reproduce the problem and I fixed it in master. Thanks for the bugreport !
There is however something fishy in Manager::Get()->RemoveAllEventSinksFor() that I'll investigate later.
Yves
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version