size of "add include path dialog"

Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

(1/2) > >>

killerbot:
IS anyone else seeing this :
(already for some months now) I have this on all my openSuse boxes :

Project->Build Options -> Search Directories -> Compiler -> Add :

Add Repository Dialog :
- a very small Directory input field (one can hardly see antyhing of the path)
- a way oversized "..." button

Note : even if this would be back to normal size as before, think this dialog should be bigger anyway (one needs space when showing paths)

ollydbg:
I think we have discussed this kind of issue already, see: Re: The 19 June 2015 build (10341) is out. about the discussion.

killerbot:
in there I think another dialog is being discussed , no ?

Without any conclusion, so what should we do.
Bluntly putting that minsize back ?

Or I think on the dialog I am mentioning, the button "..." can have a fixed sized (as well as the "Directory" label), and all the rest of the line can be consumed by the input field, together we a substantially enlarged dialog itself.

...

ollydbg:
Hi, killerbot, the dialog your reported I think is the one: "src/sdk/resources/edit_path.xrc"

With the commit 10260, some minimal size value is removed. See the diff below:

--- Code: --- src/sdk/resources/edit_path.xrc | 115 +++++++++++++++++++---------------------
1 file changed, 55 insertions(+), 60 deletions(-)

diff --git a/src/sdk/resources/edit_path.xrc b/src/sdk/resources/edit_path.xrc
index f8ec156..8ac9103 100644
--- a/src/sdk/resources/edit_path.xrc
+++ b/src/sdk/resources/edit_path.xrc
@@ -1,63 +1,58 @@
<?xml version="1.0" encoding="utf-8" ?>
<resource xmlns="http://www.wxwidgets.org/wxxrc" version="2.5.3.0">
- <object class="wxScrollingDialog" name="dlgEditPath">
- <title>Edit path</title>
- <centered>1</centered>
- <object class="wxBoxSizer">
- <orient>wxVERTICAL</orient>
- <object class="sizeritem">
- <object class="wxBoxSizer">
- <orient>wxHORIZONTAL</orient>
- <object class="sizeritem">
- <object class="wxStaticText" name="lblText">
- <label>Directory:</label>
- </object>
- <flag>wxTOP</flag>
- <border>4</border>
- </object>
- <object class="sizeritem">
- <object class="wxTextCtrl" name="txtPath"/>
- <option>1</option>
- <flag>wxLEFT|wxRIGHT|wxGROW</flag>
- <border>8</border>
- <minsize>240,-1</minsize>
- </object>
- <object class="sizeritem">
- <object class="wxButton" name="btnBrowse">
- <label>...</label>
- <tooltip>Browse</tooltip>
- </object>
- <minsize>24,24</minsize>
- </object>
- </object>
- <option>1</option>
- <flag>wxALL|wxGROW</flag>
- <border>8</border>
- </object>
- <object class="sizeritem">
- <object class="wxStaticLine"/>
- <flag>wxLEFT|wxRIGHT|wxGROW</flag>
- <border>8</border>
- </object>
- <object class="sizeritem">
- <object class="wxStdDialogButtonSizer">
- <object class="button">
- <object class="wxButton" name="wxID_OK">
- <label></label>
- <label>&Ok</label>
- <default>1</default>
- </object>
- </object>
- <object class="button">
- <object class="wxButton" name="wxID_CANCEL">
- <label></label>
- <label>&Cancel</label>
- </object>
- </object>
- </object>
- <flag>wxALL|wxALIGN_CENTRE_HORIZONTAL</flag>
- <border>8</border>
- </object>
- </object>
- </object>
+ <object class="wxScrollingDialog" name="dlgEditPath">
+ <title>Edit path</title>
+ <centered>1</centered>
+ <object class="wxBoxSizer">
+ <orient>wxVERTICAL</orient>
+ <object class="sizeritem">
+ <object class="wxBoxSizer">
+ <object class="sizeritem">
+ <object class="wxStaticText" name="lblText">
+ <label>Directory:</label>
+ </object>
+ <flag>wxTOP</flag>
+ <border>4</border>
+ </object>
+ <object class="sizeritem">
+ <object class="wxTextCtrl" name="txtPath" />
+ <flag>wxLEFT|wxRIGHT|wxEXPAND</flag>
+ <border>8</border>
+ <option>1</option>
+ </object>
+ <object class="sizeritem">
+ <object class="wxButton" name="btnBrowse">
+ <label>...</label>
+ <tooltip>Browse</tooltip>
+ </object>
+ <flag></flag>
+ </object>
+ </object>
+ <flag>wxALL|wxEXPAND</flag>
+ <border>8</border>
+ <option>1</option>
+ </object>
+ <object class="sizeritem">
+ <object class="wxStaticLine" name="ID_STATICLINE1" />
+ <flag>wxLEFT|wxRIGHT|wxEXPAND</flag>
+ <border>8</border>
+ </object>
+ <object class="sizeritem">
+ <object class="wxStdDialogButtonSizer">
+ <object class="button">
+ <object class="wxButton" name="wxID_OK">
+ <label></label>
+ </object>
+ </object>
+ <object class="button">
+ <object class="wxButton" name="wxID_CANCEL">
+ <label></label>
+ </object>
+ </object>
+ </object>
+ <flag>wxALL|wxALIGN_CENTER_HORIZONTAL</flag>
+ <border>8</border>
+ </object>
+ </object>
+ </object>
</resource>

--- End code ---

I think we should add those minimal size value back.

Jenna:
I know what happens and when.
It happens for many dialogs (I think).
I currently work on a patch to fix this.
Please do not touch this files (if possible) at least not in trunk, or fixing will be more work, because of merge conflicts.

Navigation

[0] Message Index

[#] Next page

Go to full version