Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

a Qt plugin : QtPregenForCB => AddOnForQt

<< < (8/16) > >>

oBFusCATed:
Nope. Place it next to the corresponding event. In sdk_events.h or similar header.

LETARTARE:
Hello,
-> new 'QtPregenForCB-0.6.0'


--- Quote ---In sdk_events.h or similar header
--- End quote ---
The structure 's_rebuild' is declared public in 'sdk_events.h'.

I provide a new patch to svn 10118, see to :
https://github.com/LETARTARE/QtPregenForCB

Sincerely

oBFusCATed:
OK, some more comments:
1. Why don't you use an enum instead of s_rebuild struct? An enum has the advantage that it can be extended without the need to break the api/abi.
2. The names of the events continue to be horrible. I don't know what PREGEN should mean. It has a meaning in the context of your plugin, but not as a generic event emitted by the compiler plugin.
3. Check the style guide here http://wiki.codeblocks.org/index.php?title=Coding_style and try to follow it.
4. Don't put LETARTARE everywhere. It would be removed before committing anyway.
5. Are you sure that you want to get an event when the pre-build step is executed?

@devs:
What do you think about adding an event like cbEVT_COMPILER_STEPS_STARTED?
This event will be emitted before every different step (clean, build, pre, post build, etc).
Would this make building too slow?
Also please take a look at this patch, because I have very little understanding of the compiler plugin.

LETARTARE:
@ofuscated

--- Quote ---1-  Why don't you use an enum instead of s_rebuild struct
--- End quote ---
yes it's possible, as I used three boolean, I have to use eight enums par exemple :

--- Code: ---enum cbFutureBuild
{
    fbNone = 0,
    fbBuild,
    fbClean,
    fbRebuild,
    fbWorkspaceBuild,
    fbWorkspaceClean,
    fbWorkspaceReBuild
};
--- End code ---

--- Quote ---2-The names of the events continue to be horrible
--- End quote ---
you are right : names must remember that this happens BEFORE COMPILATION

--- Quote ---'cbEVT_BEFORE_COMPILING_ALL'
'cbEVT_BEFORE_COMPILING_FILE'
??

--- End quote ---

--- Quote ---3-Check the style guide
--- End quote ---
is corrected

--- Quote ---4-Don't put LETARTARE everywhere
--- End quote ---
this is done

--- Quote ---5-  Are you sure that you want to get an event
--- End quote ---
yes, i have to generate the files required by Qt structure, BEFORE the compilation starts : see green
http://doc.qt.digia.com/qq/34/qt-build-system.png
But I will try to use 'cbEVT_COMPILER_STARTED' instead of 'cbEVT_BEFORE_COMPILING_ALL'

I will provide the patch if you agree ?

LETARTARE:
Hello,
-> new 'QtPregenForCB-0.7.1'

This version uses only event 'cbEVT_COMPILER_STARTED' associated with the relevant parameter.
The 'enum cbFutureBuild' replaces 'struct s_rebuild'.

I provide a new patch to svn10118, see to :
https://github.com/LETARTARE/QtPregenForCB

Sincerely

modification of the patch: error version !!

Navigation

[0] Message Index

[#] Next page

[*] Previous page