Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
Check macro usage on every identifier like token: issues and discussions
MortenMacFly:
--- Quote from: ollydbg on April 14, 2015, 06:25:23 am ---Hi, Morten, I attach the svn style patch which is created from this script.
--- End quote ---
That is nice, but why don't you (two) just work on a GIT repo? I could check this out via SVN and create patches myself. However, it should need to stay in sync with trunk though - so a bit more work is needed. On the pro side, Huki can commit directly and you can sync yourself with him easily.
It thought thats what the branch in the "OBF repo" was for...?! ???
ollydbg:
Hi, Morten, this is a reply after two months... How time flies. :(
I think not much people are testing my patch serials. I'm considering what is the time to let those patches into our SVN repo. I don't have a clean plan, maybe, we can let them in, and we may have more testers through nightly build versions. ;) What's your or other guy's idea?
oBFusCATed:
If you add some tests to the cctest project I am totally fine if you push these in trunk.
Then you can fix bugs and add more tests. So you won't re-introduce old problems by fixing the new ones.
If you're adding tests it should be relatively safe. Also you should be around to be able to fix if something comes up.
ollydbg:
--- Quote from: oBFusCATed on June 19, 2015, 08:30:18 pm ---If you add some tests to the cctest project I am totally fine if you push these in trunk.
Then you can fix bugs and add more tests. So you won't re-introduce old problems by fixing the new ones.
If you're adding tests it should be relatively safe. Also you should be around to be able to fix if something comes up.
--- End quote ---
OK, thanks for the suggestion, I will take two steps.
1, add more tests these days.
2, commit my patch serials only if they don't cause any regression.
ollydbg:
Currently, I see only one regression (as of revision 10341, before my patch and after applying my patch) is here:
--- Code: ------ C:/before.txt Sat Jun 20 14:14:40 2015
+++ C:/after.txt Sat Jun 20 14:09:01 2015
@@ -56,14 +56,14 @@
Total 9 tests, 9 PASS, 0 FAIL
--------------------------------------------------------
********************************************************
Testing in file: F:\cb_sf_git\trunk\src\plugins\codecompletion\testing\cc_function_ptr.cpp
********************************************************
--PASS: Fun FuncArray
+*FAIL: Fun FuncArray
-PASS: foo foo
--------------------------------------------------------
-Total 2 tests, 2 PASS, 0 FAIL
+Total 2 tests, 1 PASS, 1 FAIL
--------------------------------------------------------
********************************************************
Testing in file: F:\cb_sf_git\trunk\src\plugins\codecompletion\testing\cc_function_ptr_com_interface.cpp
********************************************************
-PASS: factory-> QueryInterface
--- End code ---
Simplify the test case, I get such test file: ccc_bug.cpp
--- Code: ---
int (*FuncArray[10][20]) ();
//Fun //FuncArray
--- End code ---
I will look into it.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version