Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

"Goto Function" Window

<< < (2/2)

oBFusCATed:
Could you try to extract the common code in either a base class or in several functions?
I'm not sure I like the code duplication there. (gotofunctiondlg vs incrementalsearchdlg)

Bat:
I've tried to do something :
https://sourceforge.net/p/codeblocks/tickets/66/

oBFusCATed:
Answered in the ticket.

@devs: Do you see any reason such a change to be rejected. I don't use this feature so I cannot comment on its usefulness. I'm commenting only on the code...

Bat:

--- Quote from: oBFusCATed on October 13, 2014, 11:58:59 pm ---For 65:
This patch looks rather dangerous to me. Who is responsible to create or destroy WindowClosed objects?
What is the value of the this pointer when the on close event is triggered?
What happens if the window is last created on the second monitor which is non-existent anymore!?

--- End quote ---

I've updated it :
https://sourceforge.net/p/codeblocks/tickets/65/

For WindowClosed object, good question for creation/deletion. I've tried to remove Class definition here, but no success. From my undesrtanding
--- Code: ---    &WindowClosed::OnWindowClosed
--- End code ---
is a member function pointer, no instance creation/destruction, static binding


--- Code: ---this
--- End code ---
pointer in
--- Code: ---OnWindowClosed
--- End code ---
is also invalid and must not be used. It acts as a pure static function. May be I missed something ?

For multi monitor, I've tested it. I've added basic check that put window back to default position if it's not enought visible on at least one screen of system

Navigation

[0] Message Index

[*] Previous page