Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

app.cpp redundency

(1/1)

sethjackson:
Hi there is some redendency in app.cpp.

wxImage::AddHandler(new handler_type);
wxImage::AddHandler(new handler_type);
wxInitAllImageHandlers();

Not good.

This patch fixes the problem.

 

thomas:
I wouldn't go as far as calling it a problem, but you're right insofar as the calls to wxImage::AddHandler() can be saved :)

Done that.

sethjackson:
Well call it what you want, but anyways thanks for fixing it. I was calling it a problem because wxInitAllImageHandlers() actually does


--- Code: ---#if wxUSE_IMAGE_TYPE
wxImage::AddHandler(new image_type);
#endif

--- End code ---

So by doing


--- Code: ---wxImage::AddHandler(new image_type);
wxImage::AddHandler(new image_type);
wxInitAllImageHandlers();

--- End code ---

I think that would create those two specfic objects twice...... No matter though.  :)

EDIT:

Could a dev close this patch then?

http://sourceforge.net/tracker/index.php?func=detail&aid=1400549&group_id=126998&atid=707418

Navigation

[0] Message Index