User forums > Nightly builds

The 22 March 2014 build (9744) is out.

<< < (9/15) > >>

ollydbg:

--- Quote from: White-Tiger on April 04, 2014, 01:10:39 pm ---and that handler function was added in r9680 ... that's why it crashes since then :P

--- End quote ---
Forgot to say that this crash is already fixed in trunk (r9746).

carra:
Abbreviations have stopped working correctly (at least under Windows) if trying to replace them when partially written. I have attached an image showing what happens instead.

This does not seem to happen when I trigger their replacement having written the full abreviation name.

carra:
OK reading my own message I'm nof sure if I have explained it correctly so I will write it as "steps to reproduce":

1) Write the beginning of some abbreviation, but leave it incomplete. for instance, using a built-in one: "tod" for today
2) Trigger auto-complete, either selecting its menu option or pressing a hotkey. The pop-up list appears, but all elements end in "?0"
3) Press enter, and instead of today's date, you will get "today?0"

Alpha:

--- Quote from: carra on April 22, 2014, 12:38:26 pm ---Abbreviations have stopped working correctly (at least under Windows) if trying to replace them when partially written. [...]

--- End quote ---
Oops, my fault.  I forgot to commit some local changes.  ... Unfortunately, the introduction of CCManager has further destabilized this feature of Abbreviations (which was already bugged, because it required event handling to be in a specific order, which it could not control).
This code will half-fix the problem (the easy part, which was sitting on my computer and hiding the problem from me).  I will try to deal with the event handling this weekend.

--- Code: ---Index: src/plugins/abbreviations/abbreviations.cpp
===================================================================
--- src/plugins/abbreviations/abbreviations.cpp (revision 9755)
+++ src/plugins/abbreviations/abbreviations.cpp (working copy)
@@ -169,6 +169,8 @@
 void Abbreviations::OnEditAutoComplete(cb_unused wxCommandEvent& event)
 {
     cbEditor* editor = Manager::Get()->GetEditorManager()->GetBuiltinActiveEditor();
+    if (!editor)
+        return;
     cbStyledTextCtrl* control = editor->GetControl();
 
     const AutoCompleteMap& acm = *GetCurrentACMap(editor);
@@ -200,6 +202,7 @@
             items.Sort();
             wxString itemsStr = GetStringFromArray(items, _T(" "));
             control->AutoCompSetSeparator(_T(' '));
+            control->AutoCompSetTypeSeparator(_T('?'));
             control->AutoCompShow(endPos-startPos, itemsStr);
         }
         m_IsAutoCompVisible = control->AutoCompActive();

--- End code ---

scarphin:
Code completion always kicks in after the 3rd character regardless of the setting in 'settings->editor->code completion->code completion tab->automatically launch when typed # letters'. It even kicks in even if the box is unchecked. Is that something by my side, a bug or intentional? I prefer the setting to be 4 and it was working correctly before.

Win7 SP1

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version