Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Notebook layout configuration (patch to test)

<< < (3/5) > >>

Jenna:

--- Quote from: jens on March 27, 2014, 07:22:10 am ---
--- Quote from: oBFusCATed on March 27, 2014, 01:33:54 am ---Can you try this workspaces: http://cmpt.benbmp.org/codeblocks/test_projects/workspace_crashs.tar.bz2

--- End quote ---
The crash is confirmed-
The cause is that the caption is not enough to distinguish between the tabs (obviously) if it's the same, so rebuilding the pane layout is broken, even if not closing any of the tabs.

--- End quote ---

Attached is a quick patch that should work unless the project/workspace path did not move.
If it has moved we run in trouble again, but that should also be fixable.
I will look into it this evening (hopefully).


EDIT:
New patch in next post.
Unfortunately the patch does not work with layout files created by the previous patch(es), so the layout files have to be cleared manually, saved with an unpatched C::B or removed.
Sorry.

Jenna:
And another one.
Should work if the project gets moved around, because it uses relative pathnames and projectname as unique identifier.
This will still fail, if two projects in one workspace have the same name and files with the same name and relative path opened.

And if a new project gets opened in an already opened workspace the actual layout will be destroyed.

Catching the first issue is not easy, the second one should be easier to fix (hopefully).

For the first one, we could of course use some kind of hash (e.g. md5), but this might slow down loading, and it will (of course) not work, if files get changed from outside, which happens often in with vcs and it will still not work if two projects share the same file.

EDIT:

Just changed the patch, to one that works with newest wx-svn.

EDIT:
actual patch in http://forums.codeblocks.org/index.php/topic,19100.msg133926.html#msg133926

LETARTARE:
@jens
I just tried this patch on svn9778, with the configuration described below.
Unfortunately it does not give the expected result.
I tried with and without plugin and the result is the same.
The first picture: two windows. The second image after reopening.

Jenna:

--- Quote from: LETARTARE on May 24, 2014, 12:25:12 pm ---@jens
I just tried this patch on svn9778, with the configuration described below.
Unfortunately it does not give the expected result.
I tried with and without plugin and the result is the same.
The first picture: two windows. The second image after reopening.

--- End quote ---
The patch should already work.
Nevertheless here comes a neweer version that tries to take care of newly loaded projects, so the perspectives of both layout-files get merged together.
All this will probably not longer work with the upcoming dynamic-aui, which will probably be merged before wx3.1.
The new aui also breaks a lot other stuff in our class derived from wxAuibook, but  have fixes for almost any problems with the dynamic aui-branch in my local repo.

EDIT:
actual patch in http://forums.codeblocks.org/index.php/topic,19100.msg133926.html#msg133926

Jenna:
If it still does not work try to remove the *.layout-files and if it still does not work, it would be great if you could send me your default.conf .

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version