Developer forums (C::B DEVELOPMENT STRICTLY!) > Plugins development

wrap char mode feature added for Editor Tweak plugin

<< < (3/7) > >>

dmoore:

--- Quote from: ollydbg on September 27, 2013, 11:23:48 am ---Does this means you have some chance that

--- Code: ---submenu->Check(id_et_TabChar,ed->GetControl()->GetUseTabs());

--- End code ---
will internally call

--- Code: ---void EditorTweaks::OnCharWrap(wxCommandEvent &/*event*/)

--- End code ---
?

In case this does change the status of id_et_TabChar (from check to unchecked or inverse), does this cause some error?
Thanks.

--- End quote ---

I think that was my reasoning for including that check. Presumably there are nicer ways of handling this.

ollydbg:

--- Quote from: dmoore on September 27, 2013, 06:06:31 pm ---
--- Quote from: ollydbg on September 27, 2013, 11:23:48 am ---Does this means you have some chance that

--- Code: ---submenu->Check(id_et_TabChar,ed->GetControl()->GetUseTabs());

--- End code ---
will internally call

--- Code: ---void EditorTweaks::OnCharWrap(wxCommandEvent &/*event*/)

--- End code ---
?

In case this does change the status of id_et_TabChar (from check to unchecked or inverse), does this cause some error?
Thanks.

--- End quote ---

I think that was my reasoning for including that check. Presumably there are nicer ways of handling this.

--- End quote ---
From my research of wx's source, I think that manually runing the functions

--- Code: ---void wxMenuBase::Check( int id, bool enable )
--- End code ---
does not cause event handler to be called, so I simply think the member variable m_isUpdatingUI is not needed here.

dmoore:
This is often a problem with GTK so I assumed it would also be a problem with wxGTK. If you are sure it isn't then go ahead and remove it.

ollydbg:

--- Quote from: dmoore on September 28, 2013, 09:32:41 pm ---This is often a problem with GTK so I assumed it would also be a problem with wxGTK. If you are sure it isn't then go ahead and remove it.

--- End quote ---
Ok, I asked this question on wx forums, and some one give me the reply, Re: wxMenu Check() cause event handler to be called?, now I need some one help to give me the result on Linux. BTW: I do have have a Linux system.

ollydbg:

--- Quote from: ollydbg on September 29, 2013, 11:10:38 am ---
--- Quote from: dmoore on September 28, 2013, 09:32:41 pm ---This is often a problem with GTK so I assumed it would also be a problem with wxGTK. If you are sure it isn't then go ahead and remove it.

--- End quote ---
Ok, I asked this question on wx forums, and some one give me the reply, Re: wxMenu Check() cause event handler to be called?, now I need some one help to give me the result on Linux. BTW: I do have have a Linux system.

--- End quote ---
Ping, any one can test this on Linux, thanks.

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version