Developer forums (C::B DEVELOPMENT STRICTLY!) > Contributions to C::B

C::B and wxWidgets 2.9.5 under Windows

<< < (7/9) > >>

MortenMacFly:

--- Quote from: oBFusCATed on October 06, 2013, 07:17:33 pm ---Morten: The place where this project is maintained.

--- End quote ---
OK. In that case its in the wxCode GIT repository at:
components\kwic\include\kwic
...but I sync'ed from there I believe... so nothing to do "upstream".

oBFusCATed:
I think, I've found a problem (minor) with wxgtk-trunk-relatively new.

Steps:
1. Settings -> Editor -> Syntax Highlight
2. Select some element in the top list control
3. Scroll with the mouse -> it doesn't scroll. Placing the mouse over the scroll bar scrolls it normally.

Can someone reproduce this on windows or another linux?

stahta01:
Patch for alert when checking "Settings" -> "Environment"

Cause was SetSettingsIconsStyle in CB globals.cpp. (Code causing alert was Windows ONLY code.)

I have NOT tested patch under wxWidgets 2.8; only  tested using wxWidgets truck (wx 3.0.0).
Edit: I have now tested the patch with wxWidgets 2.8 branch and it worked under Windows 7 32bit.

I also needed to patch CB file environmentsettingsdlg.cpp because loading the icons makes it default to displaying icons using wxWidgets truck (wx 3.0.0)

Tim S.


--- Code: ---Index: src/sdk/globals.cpp
===================================================================
--- src/sdk/globals.cpp (revision 9381)
+++ src/sdk/globals.cpp (working copy)
@@ -1020,8 +1020,8 @@
     long flags = lc->GetWindowStyleFlag();
     switch (style)
     {
-        case sisNoIcons: flags = (flags & ~wxLC_ICON) | wxLC_SMALL_ICON; break;
-        default: flags = (flags & ~wxLC_SMALL_ICON) | wxLC_ICON; break;
+        case sisNoIcons: flags = (flags & ~wxLC_MASK_TYPE) | wxLC_LIST; break;
+        default: flags = (flags & ~wxLC_MASK_TYPE) | wxLC_ICON; break;
     }
     lc->SetWindowStyleFlag(flags);
 #endif
@@ -1032,7 +1032,7 @@
 // this doesn't work under wxGTK...
 #ifdef __WXMSW__
     long flags = lc->GetWindowStyleFlag();
-    if (flags & wxLC_SMALL_ICON)
+    if (flags & wxLC_LIST)
         return sisNoIcons;
 #endif
     return sisLargeIcons;
Index: src/src/environmentsettingsdlg.cpp
===================================================================
--- src/src/environmentsettingsdlg.cpp (revision 9381)
+++ src/src/environmentsettingsdlg.cpp (working copy)
@@ -107,8 +109,8 @@
     wxXmlResource::Get()->LoadObject(this, parent, _T("dlgEnvironmentSettings"),_T("wxScrollingDialog"));
     int sel = cfg->ReadInt(_T("/environment/settings_size"), 0);
     wxListbook* lb = XRCCTRL(*this, "nbMain", wxListbook);
+    LoadListbookImages();
     SetSettingsIconsStyle(lb->GetListView(), (SettingsIconsStyle)sel);
-    LoadListbookImages();
 
     Connect(XRCID("nbMain"),wxEVT_COMMAND_LISTBOOK_PAGE_CHANGING,wxListbookEventHandler(EnvironmentSettingsDlg::OnPageChanging));
     Connect(XRCID("nbMain"),wxEVT_COMMAND_LISTBOOK_PAGE_CHANGED, wxListbookEventHandler(EnvironmentSettingsDlg::OnPageChanged ));

--- End code ---

Jenna:
I'm currently working on implementing the possibility to show/hide the settings icons with wxGTK also (after stumbling over the same issue), but it's not (yet) working as I want it (more or less minor issues on windows).
The patch touches SetSettingsIconStyles (also) and environment-, editor- and compilerdialog.

Jenna:

--- Quote from: jens on October 07, 2013, 01:21:35 am ---I'm currently working on implementing the possibility to show/hide the settings icons with wxGTK also (after stumbling over the same issue), but it's not (yet) working as I want it (more or less minor issues on windows).
The patch touches SetSettingsIconStyles (also) and environment-, editor- and compilerdialog.

--- End quote ---

Committed to trunk.

Navigation

[0] Message Index

[#] Next page

[*] Previous page