Developer forums (C::B DEVELOPMENT STRICTLY!) > Contributions to C::B
C::B and wxWidgets 2.9.5 under Windows
oBFusCATed:
Just create patches against trunk and we can talk:)
Patches against 12.11 are useless.
mojca:
I submitted a revised patch for wxWidgets 2.9 compatibility to
https://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3499&group_id=5358
As well as a few others:
* http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3496&group_id=5358
* http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3502&group_id=5358
* http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3503&group_id=5358
There are a few remaining problems, but I'm not yet sure how to (properly) fix those.
stahta01:
--- Quote from: mojca on October 01, 2013, 11:27:51 am ---
* http://developer.berlios.de/patch/index.php?func=detailpatch&patch_id=3503&group_id=5358
--- End quote ---
The changes to scintilla code will likely need submitted upstream to them for the changes to be put into CB.
IIRC, Morton updates the scintilla code from time to time from the upstream.
Edit3: I noticed these in the scintilla code section; so if doing non upstream changes it might help you get the patch applied.
--- Code: ---/* C::B begin */
/* C::B end */
--- End code ---
I also suggest looking at the Category options when submitting patches.
If you think some are really bugs; please submit a bug report on them linking to the patch.
NOTE: I am NOT a CB dev; so, all I am saying are suggestions; not required. I gave up doing patches and stuff due to the work it took to keep them updated for CB trunk. But, yours are shorter; maybe my problem was patching to much in a single patch.
Tim S.
oBFusCATed:
--- Quote from: stahta01 on October 01, 2013, 03:23:05 pm ---I gave up doing patches and stuff due to the work it took to keep them updated for CB trunk.
--- End quote ---
What should this mean? We haven't apply some of your patches?
stahta01:
--- Quote from: oBFusCATed on October 01, 2013, 04:07:05 pm ---
--- Quote from: stahta01 on October 01, 2013, 03:23:05 pm ---I gave up doing patches and stuff due to the work it took to keep them updated for CB trunk.
--- End quote ---
What should this mean? We haven't apply some of your patches?
--- End quote ---
I had patches that took many months to be applied; to keep updating them to trunk took a long time.
Then, I had to add all the unnecessary ifdefs because of the lack of documentation in wxWidgets of wxstr function.
I felt like it was a waste of my time to submit patches after awhile.
I believe my SDL patch for the wizard has still NOT been applied; but, I gave up on it long ago.
Tim S.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version