Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Move Occurrence highlighting from core into a plugin
danselmi:
Hi
As mentioned here:
http://forums.codeblocks.org/index.php/topic,18070.msg123704.html#msg123704
I moved the code of the occurrence highlighting from sdk and the mentioned plugin into a core-plugin. Patch is attached.
Does anybody have some time to
* prepare the auto foo magic
* review
* provide an image (on and off) for the config dialog
Regards,
daniel
[attachment deleted by admin]
Jenna:
I can do the automake-stuff (in fact I just started doing it).
I will also have a quick look into the sources/headers.
I will see if I can make iamges also. Most likely made of a screenshot, similar to IncSearch.
Jenna:
Here comes a first addition to your patch.
It has to be applied after yours.
I can put it in one patch, but it will be more difficult to see the changes I made.
I did not (yet) update the wx2.9 project-files.
Hopefully tomorrow.
Now I go to bed.
ollydbg:
Good work, I did not test the patch, just quick read the patch file:
--- Code: ---Index: src/plugins/occurrenceshighlighting/highlighter.cpp
===================================================================
--- src/plugins/occurrenceshighlighting/highlighter.cpp (revision 0)
+++ src/plugins/occurrenceshighlighting/highlighter.cpp (working copy)
@@ -0,0 +1,356 @@
+#include "Highlighter.h"
+
+#include <sdk.h> // Code::Blocks SDK
+//#include <editorcolourset.h>
+#include <cbstyledtextctrl.h>
+#include <cbcolourmanager.h>
--- End code ---
Is it better to put sdk.h as the first include files?
--- Code: ---+#ifndef Highlighter_h
+#define Highlighter_h
--- End code ---
and
--- Code: ---+#ifndef OCCURRENCESHIGHLIGHTING_H_INCLUDED
+#define OCCURRENCESHIGHLIGHTING_H_INCLUDED
--- End code ---
I would suggest to use a uniform string. like XXXXX_H
MortenMacFly:
Well I cannot apply Jens' patch (I assume its GIT based again), but the part of Daniel works fine for me so far. Nice work!
Navigation
[0] Message Index
[#] Next page
Go to full version