Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign
CC plugin interface redesign
jarod42:
In this example, it seem that there are several "returned" values (int&).
So, I think it is better to have something similar for all these items (so the return void solution).
Order may also be important, I prefer generally ([in], [in/out], [out]) order.
Alpha:
--- Quote from: oBFusCATed on September 16, 2013, 10:01:02 am ---c++11: The first one is almost always better.
--- End quote ---
I do not believe it is yet time to restrict Code::Blocks to the new standard, so:
--- Quote from: oBFusCATed on September 16, 2013, 10:01:02 am --- - Is the copy really expensive (many elements in the vector)?
- Will it be called many times and so the copy will show in the profiler?
--- End quote ---
It occurs each time the auto-complete box is populated. I do not have exact numbers, however sometimes the number of tokens is large; as this can be a user requested operation, I think it would be best to minimize any potential sense of lag. (Unfortunately, I currently do not have access to average/slower hardware, so I cannot tell if it is yet noticeable. 8) Only having access to fast computers is a problem I like having.)
I think it might be best to go with the second style. Which brings up:
--- Quote from: jarod42 on September 16, 2013, 11:36:04 am ---Order may also be important, I prefer generally ([in], [in/out], [out]) order.
--- End quote ---
I normally try to order parameters such that the ones that are most important/vital to the main purpose of function come first, and less useful (possibly omit-able) parameters are last. Does Code::Blocks already have a design style in reference to this?
To anyone who might be currently trying (or considering trying) my branch, it currently should have all the functionality of the trunk except for automatic adding of parentheses after functions, and documentation popups. Probably the only visible change is that tooltips should be a bit more stable.
oBFusCATed:
--- Quote from: Alpha on September 28, 2013, 02:13:20 am ---It occurs each time the auto-complete box is populated. I do not have exact numbers, however sometimes the number of tokens is large; as this can be a user requested operation, I think it would be best to minimize any potential sense of lag. (Unfortunately, I currently do not have access to average/slower hardware, so I cannot tell if it is yet noticeable. 8) Only having access to fast computers is a problem I like having.)
--- End quote ---
1. There is a limit to the number of entries this should return in the UI.
2. You can always downclock your CPU and you can disable cores to test. Turn you CPU in a single core 1.5ghz and test again :)
--- Quote from: jarod42 on September 16, 2013, 11:36:04 am ---Order may also be important, I prefer generally ([in], [in/out], [out]) order.
--- End quote ---
I'd follow this one, because it is clear what is in and out parameter.
Alpha:
--- Quote from: oBFusCATed on September 28, 2013, 11:25:55 am ---1. There is a limit to the number of entries this should return in the UI.
--- End quote ---
Yes, but the default limit is currently so high, I do not believe I have ever hit it.
--- Quote from: oBFusCATed on September 28, 2013, 11:25:55 am ---2. You can always downclock your CPU and you can disable cores to test. Turn you CPU in a single core 1.5ghz and test again :)
--- End quote ---
Downclocked, disabled turbo, and disabled hyperthreading. For some reason, the BIOS failed to disable extra cores. When asking for a long auto-complete list (for example, code complete after the letter 's'), I did notice an additional lag.
--- Quote from: oBFusCATed on September 28, 2013, 11:25:55 am ---
--- Quote from: jarod42 on September 16, 2013, 11:36:04 am ---Order may also be important, I prefer generally ([in], [in/out], [out]) order.
--- End quote ---
I'd follow this one, because it is clear what is in and out parameter.
--- End quote ---
Okay. Will do.
oBFusCATed:
--- Quote from: Alpha on September 28, 2013, 03:54:25 pm ---I did notice an additional lag.
--- End quote ---
Have you measured how long more does it take?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version