Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Parse enumerator assignment

<< < (2/2)

Alpha:
No, I have not added test cases yet; I will try to this weekend.

ollydbg:
Just applied your patch (not test yet), and I see that the major part of your patch is handling the assignment.
Looks really nice.
So some suggestions:


--- Code: ---        // assignments (=xxx) are ignored by the tokenizer,
        // so we don't have to worry about them here ;)

--- End code ---
These two comment lines should be removed.

Maybe, add comments like:

--- Code: ---enumerator->m_Args += peek; //emulator values were stored in m_Args field of the Token
--- End code ---


--- Code: ---
                        // emulator value string may have two types, hex value with prefix "0x" or decimal value
                        if (lastEnumerator->m_Args.StartsWith(wxT("0x")))

--- End code ---

Alpha:
Attached patch has better comments (functionality is the same).  I will write test cases, and then probably commit if no problems are identified.

Navigation

[0] Message Index

[*] Previous page