Code completion occurring inside comments

[zabzonk]

Using C::B 12.11, I am getting code completion popping up inside C++ comments. Am I alone in this (I did search before posting), and is there an easy way of stopping it? Screenshot here http://imgur.com/bL9VtGb .

[oBFusCATed]

I'd rather say this is a feature (at least for me)

[zabzonk]

Well, it's not for me! I find it intensely irritating having CC pop up when I'm writing non-program text. At the very least, it should be optional.

[ollydbg]

I think it is a cc bug, I can't reproduce this issue.

[Alpha]

The guard:
codecompletion.cpp: 2874

Code

    if (   control->IsString(style)
        || control->IsComment(style)
        || control->IsCharacter(style)
        || control->IsPreprocessor(style) )
    {
        return;
    }

should already prevent this.  Can you post a test case this behavior is occurring on?

[zabzonk]

Further investigation indicates that the behaviour is actually quite bizarre. If I create a new header file in a console project and start adding C++-style comments (but nothing else - no actual code), then the first word that can cause CC to fire will do so. So, if I enter;

Code

// this

then the code completion list pops up for "this", and for any other completable words as type them. If I enter a newline, then it seems the behaviour goes back to normal, and no CC takes place in the comment.  So it looks like the code for IsComment() may be a bit buggy.

[ollydbg]

...So it looks like the code for IsComment() may be a bit buggy.

I agree with you, you can report to scintilla .

[danselmi]

IsComment(style) is part of cbStyledTextCtrl not scintilla!

[Jenna]

IsComment(style) is part of cbStyledTextCtrl not scintilla!

The problem is the control->GetStyleAt() function, that always returns 0 as style for the last position of a document.
And that's a Scintilla issue.

[zabzonk]

Is this a new Scintilla issue? Because I'm pretty positive it didn't happen prior to C::B 12.11.

Edit: Oh, yes it does (just tested it) - I wonder why I've never noticed it before?

[Jenna]

IsComment(style) is part of cbStyledTextCtrl not scintilla!

The problem is the control->GetStyleAt() function, that always returns 0 as style for the last position of a document.
And that's a Scintilla issue.

Maybe not an issue, because the last postion is not styled at all, so retuzrning a zero.style might be considered the correct way to handle it.

I attach a patch with a quick (and more or less ugly) fix for this.
If the caret is on last position of a document (with length > 0) we use the style for the last character.

[Jenna]

IsComment(style) is part of cbStyledTextCtrl not scintilla!

The problem is the control->GetStyleAt() function, that always returns 0 as style for the last position of a document.
And that's a Scintilla issue.

Maybe not an issue, because the last postion is not styled at all, so retuzrning a zero.style might be considered the correct way to handle it.

I attach a patch with a quick (and more or less ugly) fix for this.
If the caret is on last position of a document (with length > 0) we use the style for the last character.

Any comments ?

[MortenMacFly]

Any comments ?

No, seems to work here - at lest I see not negative side-effects.