Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

Patch 3407: correctly parse c++98 enums

(1/5) > >>

oBFusCATed:
Can someone with better knowledge review this patch? Is it possible to add tests for it?
This is a major problem of the current parser and I'd be happy if it is fixed.

I'll apply the patch on my work version of C::B and will give it some testing.

Probably C++11's strong enums (fake) parsing will be broken by this patch, but for me supporting the old enums is preferable.

https://developer.berlios.de/patch/?func=detailpatch&patch_id=3407&group_id=5358

killerbot:
please keep the enum class also working.

oBFusCATed:

--- Quote from: killerbot on January 21, 2013, 07:33:00 am ---please keep the enum class also working.

--- End quote ---
Does they really work or it is just illusion, because of the bug? :)
Apply the patch and test. Then provide feedback...

p.s. I knew you'll would post this :)
p.p.s. c++11 enums are still horrible, the improvement is close to none. (don't flame on this, I don't care)

MortenMacFly:

--- Quote from: killerbot on January 21, 2013, 07:33:00 am ---please keep the enum class also working.

--- End quote ---
Dunno what that means?! What class?


--- Quote from: oBFusCATed on January 21, 2013, 09:28:52 am ---Does they really work or it is just illusion, because of the bug? :)

--- End quote ---
Applied in my local copy... test cases can be added here, if you like:
https://svn.berlios.de/svnroot/repos/codeblocks/trunk/src/plugins/codecompletion/testing/structs_typedefs.cpp
...renaming it to something like structs_typedefs_enums.cpp ... harhar...

Will report back...

killerbot:
I will test the tomorrow, to see if it still works for enum class.
Will report back ...

Navigation

[0] Message Index

[#] Next page

Go to full version