Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

FindTargetsDebugger bypassed on workspace load

<< < (2/2)

MortenMacFly:

--- Quote from: Pecan on December 19, 2012, 12:27:09 pm ---Yes, of course. It uses the gdb/cdb debugger when it should have used the gdb/mi debugger.

--- End quote ---
I think Pecan is right - I've tried with a debug output and I can reproduce. Looking at the patch it won't break anything I guess - but I did not try yet if it works (but I guess Pecan did... ;-)).

MortenMacFly:

--- Quote from: Pecan on December 18, 2012, 02:45:43 pm ---
--- Code: ---+    Manager::Get()->RegisterEventSink(cbEVT_PROJECT_OPEN, new Event(this, &DebuggerManager::OnProjectActivated));

--- End code ---
solves the problem, since at that call, IsLoadingOrClosing() is false.

--- End quote ---
One question: Should this not replace this:

--- Code: ---Manager::Get()->RegisterEventSink(cbEVT_PROJECT_ACTIVATE, new Event(this, &DebuggerManager::OnProjectActivated));
--- End code ---
??

Pecan:

--- Quote from: MortenMacFly on December 19, 2012, 05:52:42 pm ---
--- Quote from: Pecan on December 18, 2012, 02:45:43 pm ---
--- Code: ---+    Manager::Get()->RegisterEventSink(cbEVT_PROJECT_OPEN, new Event(this, &DebuggerManager::OnProjectActivated));

--- End code ---
solves the problem, since at that call, IsLoadingOrClosing() is false.

--- End quote ---
One question: Should this not replace this:

--- Code: ---Manager::Get()->RegisterEventSink(cbEVT_PROJECT_ACTIVATE, new Event(this, &DebuggerManager::OnProjectActivated));
--- End code ---
??

--- End quote ---

I did not simple want to replace cbCVT_PROJECT_ACTIVATED because of all the unknown conditions now existing around those project events.

It used to be that  cbCVT_PROJECT_ACTIVATED was called twice, once with a null project pointer (meaning ACTIVATING) and once with a valid pointer (meaning NOW ACTIVATED).

We now have a new condition (since the code was modified to accomodate CC) and an event cbEVT_PROJECT_OPEN which now means what the second cbEVT_PROJECT_ACTIVATED used to mean.

So I took the cautious (or cowardly) way out.

Edit: and yes, I tested it for days before proposing the fix.

Navigation

[0] Message Index

[*] Previous page