Patch: function arguments added to autocomplete tooltip

[ollydbg]

Gui added, last bugs fixed... It seems to be finished now http://developer.berlios.de/patch/?func=detailpatch&patch_id=3381&group_id=5358

(Ability to define custom sort order had been removed from this patch, so remember to clean your configuration file.)

Thanks! the patch is big, so I just apply the patch, and build it. I see two build warnings:
1,

Code

plugins\codecompletion\codecompletion.cpp|1658|warning: extended initializer lists only available with -std=c++0x or -std=gnu++0x [enabled by default]|

The code is:

Code

                        ccSearchData searchData { control, editor->GetFilename() };

So, it would better:

Code

ccSearchData searchData= { control, editor->GetFilename() };

2,

Code

plugins\codecompletion\doxygen_parser.cpp|559|warning: comparison between signed and unsigned integer expressions [-Wsign-compare]|

Here

Code

    for(int i = 0; i < (size_t)(sizeof(arguments)/sizeof(arguments[0])); ++i )

i should be unsigned int.

 

[killerbot]

size_t

[p2rkw]

Ok, I'll fix it in next few days.

[MortenMacFly]

Ok, I'll fix it in next few days.

I did that already besides quite some other refinements. It did neither compile with wx29 nor under 64 bit. The include chain was wrong, you defined types twice and so on... Nothing serious, but it needed to be fixed. Maybe I should post an updated patch... Just I need to sort out the stuff...

[p2rkw]

It will be nice.
Actually I added auto hide to documentation window. It's only few lines of code, but makes this window much less annoying.

[MortenMacFly]

It will be nice.
Actually I added auto hide to documentation window. It's only few lines of code, but makes this window much less annoying.

Update the patch, I can integrate. I'll provide a refined one after that. Otherwise we move in circles.. ;-)

[p2rkw]

Update the patch

Done.

[ollydbg]

Slightly unrelated, but I thought I would mention that if one can get the Scintilla lexers to run invisibly (for files not currently open), a relatively simple language independent comment parser can be created with cbStyledTextCtrl::IsComment().

@Alpha, in plugins\codecompletion\coderefactoring.cpp, function
size_t CodeRefactoring::SearchInFiles(const wxArrayString& files, const wxString& targetText)
There is some usage of an invisible cbStyledTextCtrl, and fill it with the text, and I think later use cbStyledTextCtrl::IsXXXX() to check styles. EDIT: I'm not look deep into p2rkw's patch, but I think using a invisible cbStyledTextCtrl is an alternative way to catch document strings on the fly.

@All:
I'm looking forward to see the updated patch against SVN HEAD .

Also:
"return wxString();"should use wxEmptyString, right?

[MortenMacFly]

Also:
"return wxString();"should use wxEmptyString, right?

Yes, I've done all such adjustments already in my local copy. I still need to merge and sort out from/with trunk as there have been many CC related changes recently. If I find the time for that I can provide a cleaned-up patch. The patch in the patch-tracker if of no use anymore. Hence it also doesn't make sense for p2rkw to work on that - I've done it already, just not to public. I am still on it - its not lost... don't worry.

[Alpha]

@p2rkw: How difficult would it be to extend the parser to accept comments on more complicated declarations, ex. the following from stl:

Code

  /**
   *  @brief This does what you think it does.
   *  @ingroup sorting_algorithms
   *  @param  a  A thing of arbitrary type.
   *  @param  b  Another thing of arbitrary type.
   *  @return   The lesser of the parameters.
   *
   *  This is the simple classic generic implementation.  It will work on
   *  temporary expressions, since they are only evaluated once, unlike a
   *  preprocessor macro.
  */
  template<typename _Tp>
    inline const _Tp&
    min(const _Tp& __a, const _Tp& __b)
    {
      // concept requirements
      __glibcxx_function_requires(_LessThanComparableConcept<_Tp>)
      //return __b < __a ? __b : __a;
      if (__b < __a)
	return __b;
      return __a;
    }

[p2rkw]

Alpha: thanks for info, I'll try to fix it in next few days.

[p2rkw]

Attached patch fixes issue reported by Alpha. Multi line declarations should be handled properly now.
Edit: patch removed.

[Alpha]

Testing (and your other patch)...

[Alpha]

This patch works.

[Alpha]

Do these functions have a purpose?

Code

F:\cb\src\plugins\codecompletion\doxygen_parser.cpp:26:12: warning: 'int GetAverangeCharWidth(cbStyledTextCtrl*, int)' defined but not used [-Wunused-function]
F:\cb\src\plugins\codecompletion\parser\tokentree.cpp:96:17: warning: 'bool TokenTreeHelper::CompareBaseArguments(const wxString&, const wxString&)' defined but not used [-Wunused-function]