User forums > Nightly builds
The 07 October 2012 build (8438) is out.
dmoore:
--- Quote from: rickg22 on October 13, 2012, 03:33:22 pm ---The Find in files function doesn't remember the search path / mask state anymore. Worse, if I click on the "..." to pick the path, it goes all the way back to "My Computer". This is so annoying >:( because I have to find on a huge project, and the only way to save time is to use that feature.
Mind fixing it please?
--- End quote ---
Probably my fault. I'll take a look.
Alpha:
--- Quote from: dmoore on October 13, 2012, 04:01:22 pm ---
--- Quote from: rickg22 on October 13, 2012, 03:33:22 pm ---The Find in files function doesn't remember the search path / mask state anymore. Worse, if I click on the "..." to pick the path, it goes all the way back to "My Computer". This is so annoying >:( because I have to find on a huge project, and the only way to save time is to use that feature.
Mind fixing it please?
--- End quote ---
Probably my fault. I'll take a look.
--- End quote ---
--- Code: ---Index: src/sdk/findreplacedlg.cpp
===================================================================
--- src/sdk/findreplacedlg.cpp (revision 8454)
+++ src/sdk/findreplacedlg.cpp (working copy)
@@ -140,6 +140,13 @@
ProjectsArray *pa = pm->GetProjects();
cbProject *active_project = Manager::Get()->GetProjectManager()->GetActiveProject();
+ // load search path options
+ XRCCTRL(*this, "txtSearchPath", wxTextCtrl)->SetValue(cfg->Read(CONF_GROUP _T("/search_path"),
+ (active_project ? active_project->GetBasePath() : wxT(""))));
+ XRCCTRL(*this, "txtSearchMask", wxTextCtrl)->SetValue(cfg->Read(CONF_GROUP _T("/search_mask")));
+ XRCCTRL(*this, "chkSearchRecursively", wxCheckBox)->SetValue(cfg->ReadBool(CONF_GROUP _T("/search_recursive"), false));
+ XRCCTRL(*this, "chkSearchHidden", wxCheckBox)->SetValue(cfg->ReadBool(CONF_GROUP _T("/search_hidden"), false));
+
wxChoice *chProject = XRCCTRL(*this, "chProject", wxChoice);
wxChoice *chTarget = XRCCTRL(*this, "chTarget", wxChoice);
for(unsigned int i=0;i<pa->size();++i)
@@ -302,6 +309,11 @@
cfg->Write(CONF_GROUP _T("/scope2"), XRCCTRL(*this, "rbScope2", wxRadioBox)->GetSelection());
cfg->Write(CONF_GROUP _T("/delete_old_searches2"), XRCCTRL(*this, "chkDelOldSearchRes2", wxCheckBox)->GetValue());
+ cfg->Write(CONF_GROUP _T("/search_path"), XRCCTRL(*this, "txtSearchPath", wxTextCtrl)->GetValue());
+ cfg->Write(CONF_GROUP _T("/search_mask"), XRCCTRL(*this, "txtSearchMask", wxTextCtrl)->GetValue());
+ cfg->Write(CONF_GROUP _T("/search_recursive"), XRCCTRL(*this, "chkSearchRecursively", wxCheckBox)->GetValue());
+ cfg->Write(CONF_GROUP _T("/search_hidden"), XRCCTRL(*this, "chkSearchHidden", wxCheckBox)->GetValue());
+
if (m_findPage!=0)
m_findPage->Destroy();
--- End code ---
dmoore:
Thanks Alpha. I'll test and commit. As we discussed elsewhere, it's still on my mind to look into merging the best bits of incremental search and thread search behavior into the built in find/replace.
dmoore:
Fix applied in 8455,
rickg22:
Thanks! Oh, btw, I edited my above reply, but here is it again: If you leave the "search path" field blank, C::B hangs (for around a minute at least) when searching.
And now that we're at it, I was wondering if you could move the search path / filemask functionality outside the radiobox; Sometimes we want to search inside the project/open files with a path or mask restriction. (I was planning to do it myself, but my free time dropped to zero back then, sorry.
Anyway, bugs first, features later ;-)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version