Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
SmartIndent refactoring question
Jenna:
--- Quote from: MortenMacFly on November 06, 2012, 10:04:10 am ---
--- Quote from: jens on November 06, 2012, 09:12:03 am ---I will look into it as soon as possible.
--- End quote ---
A very easy solution would be to move the manifest into sub-folders "HDL", "Cpp".... Then you don't need to rename and can run the ZIP commands in parallel w/o hassle.
--- End quote ---
@killerbot:
can you test the following patch, please:
--- Code: ---Index: src/plugins/contrib/SmartIndent/Makefile.am
===================================================================
--- src/plugins/contrib/SmartIndent/Makefile.am
+++ src/plugins/contrib/SmartIndent/Makefile.am
@@ -99,6 +99,8 @@
CLEANFILES = $(pkgdata_DATA)
+.NOTPARALLEL: $(pkgdata_DATA)
+
SmartIndentHDL.zip: manifest_hdl.xml
PWD=`pwd` cd $(srcdir) && \
cp manifest_hdl.xml ./manifest.xml && \
--- End code ---
I can build with it, but there haven't been any issues before (with -j 2).
I tested with -j 4, but I have just a core2duo, so I might not have enough cores to break the build.
Alpha:
--- Quote from: jens on November 08, 2012, 12:57:22 am ---
--- Code: ---+.NOTPARALLELL: $(pkgdata_DATA)
--- End code ---
--- End quote ---
Slightly off topic, but "parallel" is spelled with only one "l" at the end (so I assume this means a double "l" ending is the secret code used throughout the build system ;)).
Jenna:
--- Quote from: Alpha on November 08, 2012, 02:13:08 am ---
--- Quote from: jens on November 08, 2012, 12:57:22 am ---
--- Code: ---+.NOTPARALLELL: $(pkgdata_DATA)
--- End code ---
--- End quote ---
Slightly off topic, but "parallel" is spelled with only one "l" at the end (so I assume this means a double "l" ending is the secret code used throughout the build system ;)).
--- End quote ---
Oops, thank you.
I corrected the patch above.
killerbot:
yes, that works, I have committed this fix.
Navigation
[0] Message Index
[*] Previous page
Go to full version