Developer forums (C::B DEVELOPMENT STRICTLY!) > CodeCompletion redesign

variable/type name question

(1/2) > >>

ollydbg:

--- Code: ---    // pair of current-file-filter
    TokenFilesSet    m_CurrentFileSet;
    TokenIdxSet      m_CurrentTokenSet;
    TokenIdxSet      m_CurrentGlobalTokensSet;

--- End code ---

and:

--- Code: ---for (TokenFilesSet::const_iterator itf = m_CurrentFileSet.begin(); itf != m_CurrentFileSet.end(); ++itf)

--- End code ---

See, we have XXXXsSet or XXXXSet?
I think we should choose one kind of name theme for all the source files.

EDIT:
Just query on Google, like:

"fileVector" filetype:cpp   -> 1440 results
"filesVector" filetype:cpp -> 75 results

"threadpool" filetype:cpp -> 23600 results
"threadspool" filetype:cpp  -> 10 results

Compare the other similar result, we should use XXXXSet, right?
 

MortenMacFly:

--- Quote from: ollydbg on August 31, 2012, 03:49:45 am ---Compare the other similar result, we should use XXXXSet, right?

--- End quote ---
Yes.

ollydbg:

--- Quote from: MortenMacFly on August 31, 2012, 06:20:27 am ---
--- Quote from: ollydbg on August 31, 2012, 03:49:45 am ---Compare the other similar result, we should use XXXXSet, right?

--- End quote ---
Yes.

--- End quote ---
OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

MortenMacFly:

--- Quote from: ollydbg on August 31, 2012, 06:44:51 am ---OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

--- End quote ---
Oh dear... some more effort... but yes.

ollydbg:

--- Quote from: MortenMacFly on August 31, 2012, 11:07:24 am ---
--- Quote from: ollydbg on August 31, 2012, 06:44:51 am ---OK, so we need to re-factor on those names, also it looks like "tokenstree.h/cpp" should be "tokentree.h/cpp".

--- End quote ---
Oh dear... some more effort... but yes.

--- End quote ---
I did a lot of names change in rev 8364, please help to change the file names. That may change the makefiles also which I don't familiar. Thanks.

Navigation

[0] Message Index

[#] Next page