User forums > Help

EOL issue, the EOL should be automatically detected, and make consistent

<< < (6/6)

dmoore:
Don't we set a CR for wxMAC in a few places? (E.g. the default when the user first uses C::B on a mac?)I think whatever behavior we have should be consistent in all places.

ollydbg:

--- Quote from: dmoore on August 29, 2012, 03:25:56 am ---Don't we set a CR for wxMAC in a few places? (E.g. the default when the user first uses C::B on a mac?)I think whatever behavior we have should be consistent in all places.

--- End quote ---
This is the old behavior in cbEditor.cpp

--- Code: ---control->SetEOLMode(                  mgr->ReadInt(_T("/eol/eolmode"),                   platform::windows ? wxSCI_EOL_CRLF : wxSCI_EOL_LF)); // Windows takes CR+LF, other platforms LF only

--- End code ---
If the user does not select an eol mode, or read eol from configure manager failed, we use either CRLF(windows) or LF(non-windows). So, I think my new patch is just consistent with the old behavior.

EDIT:
I just search the C::B source, and it looks like the CR is the old mac EOL style, see:
plugins\astyle\astyle\astyle_main.h

--- Code: ---int eolWindows;        // number of Windows line endings, CRLF
int eolLinux;          // number of Linux line endings, LF
int eolMacOld;         // number of old Mac line endings. CR

--- End code ---
eolMacOld

ollydbg:
Committed in trunk rev 8332, thanks for everyone's suggestion.

Navigation

[0] Message Index

[*] Previous page