Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Two problems with r8232

<< < (5/5)

Alpha:

--- Quote from: Alpha on August 16, 2012, 03:32:40 am ---This patch should fix (almost) all custom color scheme loading problems.

--- End quote ---
Never mind; it only worked by a fluke.

--- Quote from: Alpha on August 16, 2012, 03:32:40 am ---
--- Quote from: oBFusCATed on August 15, 2012, 09:05:16 pm ---BTW: Is there any reason that the syntax highlight preview looks correct, so the code is different

--- End quote ---
I have no idea how this happens (and I cannot reproduce it).

--- End quote ---
I had misunderstood the way color schemes were loaded/saved.  Items with multiple indexes are actually saved once for each index, which is why the preview looked different than the actual code.  The preview reinitialized all the values, however the actual code loaded (in this case) style "Comment (normal)" into the second index (11) that I added to "Default".


--- Quote from: MortenMacFly on August 16, 2012, 06:04:39 am ---An exec command every time? Couldn't this be at least cached? Maybe that should even be a function of the compiler... (not a specific one, but the compiler framework. Because the compile has to do it, too IIRC... (I want to avoid having duplicate code.)

--- End quote ---
Right; I just noticed this now makes switching build targets a little slow.
Making wxString ExpandBackticks(wxString& str) (from sdk/compilercommandgenerator.cpp) global (and BackticksMap m_Backticks) looks like a solution.

Alpha:
This time, I think I got the loading function to work properly.  (The save function is currently unmodified, so file format is currently backwards compatible, but not as efficient as it could be.)  Execution is now cached in a globally accessible location.

oBFusCATed:

--- Quote from: MortenMacFly on August 16, 2012, 01:22:23 pm ---Huh? This patch is needed in one to work. There is nothing to separate, or what did you mean? Collecting preprocessor defines is needed fr the highlighting function to work correctly.

--- End quote ---
Sorry, but the patch explanation made me believe the patch can be applied in two steps and there are some optional parts.

Alpha:

--- Quote from: oBFusCATed on August 16, 2012, 06:45:27 pm ---
--- Quote from: MortenMacFly on August 16, 2012, 01:22:23 pm ---Huh? This patch is needed in one to work. There is nothing to separate, or what did you mean? Collecting preprocessor defines is needed fr the highlighting function to work correctly.

--- End quote ---
Sorry, but the patch explanation made me believe the patch can be applied in two steps and there are some optional parts.

--- End quote ---
My fault; I failed to describe the connection to the original patch (which inadvertently caused the problems).

Alpha:
In patch tracker so it does not get lost.

Navigation

[0] Message Index

[*] Previous page