Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Two problems with r8232
Pecan:
--- Quote from: oBFusCATed on August 15, 2012, 09:37:45 am ---
--- Quote from: MortenMacFly on August 15, 2012, 06:45:55 am ---I still don't get what the problem is here really., I don't have such issue - it works just fine. What modifications are we talking about? There is no new functionality in the editor's "Syntax highlight" options...?!
--- End quote ---
The problem is that between 8164 and 8232 something changed and now some strings are gray instead of black as they were before the upgrade.
I have no time to bisect it to find the wrong revision, unfortunately.
--- End quote ---
I also completely lost my custom editor highlighting with the current SVN.
Every color I'd previously set was now a different color. This was/is a hugh pain in the butt. I finally gave up on attempting to save my color scheme and deleted the .conf, starting over again.
Alpha:
--- Quote from: oBFusCATed on August 15, 2012, 09:37:45 am ---
--- Quote from: MortenMacFly on August 15, 2012, 06:45:55 am ---I still don't get what the problem is here really., I don't have such issue - it works just fine. What modifications are we talking about? There is no new functionality in the editor's "Syntax highlight" options...?!
--- End quote ---
The problem is that between 8164 and 8232 something changed and now some strings are gray instead of black as they were before the upgrade.
I have no time to bisect it to find the wrong revision, unfortunately.
--- End quote ---
It happened here:
--- Quote from: Alpha on August 14, 2012, 12:43:52 am ---rev8230 shifts many of the items in the C/C++ lexer [...]
--- End quote ---
Specifically:
--- Code: ---http://svn.berlios.de/wsvn/codeblocks?op=comp&compare[]=/trunk/src/sdk/resources/lexers/lexer_cpp.xml@8229&compare[]=/trunk/src/sdk/resources/lexers/lexer_cpp.xml@8230
--- End code ---
The change made here enables code that is greyed out by preprocessor commands to still be syntax highlighted (previously it all just turned black).
(This does, in my opinion, make code much more readable, however) In order to achieve it, I had to add many new sections to lexer_cpp.xml. The addition of new sections means that loading custom color schemes (by the current system) will apply the saved data to the wrong sections (due to the offset).
--- Quote from: oBFusCATed on August 14, 2012, 10:54:29 pm ---So, I guess, the changes to the lexer have to be reverted, as I predict massive amount of unhappy users attacking the forum.
--- End quote ---
--- Quote from: Pecan on August 15, 2012, 02:06:05 pm ---I also completely lost my custom editor highlighting with the current SVN.
--- End quote ---
Sorry.
I think a temporary partial revert of the file src/sdk/resources/lexers/lexer_cpp.xml might be the best option. I have an idea that could resolve this issue, but it may be some time before I have a working patch.
MortenMacFly:
--- Quote from: Alpha on August 15, 2012, 02:48:16 pm ---Sorry.
I think a temporary partial revert of the file src/sdk/resources/lexers/lexer_cpp.xml might be the best option. I have an idea that could resolve this issue, but it may be some time before I have a working patch.
--- End quote ---
Thanks for the explanation. Its not nice, but actually the wrong part is the loading of the lexers. I guess we will change these lexer files form time to time and as I understand everytime we do so, the custom syntax highlighting will be broken.
Now I also understand why I don't see it. I don't have custom syntax highlighting - so I was just seeing the improvement. 8)
So the question is: Shall we really revert, or actually fix the loading? Nevertheless fixing the loading might not mean to necessarily also update old schemes though. :-\
oBFusCATed:
--- Quote from: MortenMacFly on August 15, 2012, 08:39:38 pm ---So the question is: Shall we really revert, or actually fix the loading? Nevertheless fixing the loading might not mean to necessarily also update old schemes though. :-\
--- End quote ---
If you plan to have a nightly build, before this problem is fixed, you'll have to revert it as there will be many people which will suffer and many people will complain, so the will put some suffering on our shoulders.
If there is no plan for a nightly and you plan to fix it in the next couple of weeks, I'm OK with not reverting it.
Funnily, I thought, I have not modified my highlighting, but I carry my home dir with all the upgrades/reinstalls, so I might have some changes done many years ago.
oBFusCATed:
BTW: Is there any reason that the syntax highlight preview looks correct, so the code is different, I think this is pretty bad, don't you think so?
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version