Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Some UI refactoring/tidy up
Alpha:
--- Quote from: oBFusCATed on August 31, 2012, 09:22:12 pm ---Thread search provides on better option View -> Focus Thread search. I've a key bound to it and I'm using it all the time.
In combination with a disabled option of "Delete previous entries before search" this is the best searcher in town.
--- End quote ---
I agree; Thread search is currently the best large search option in Code::Blocks. However my personal preference is that the UI for Find in files is nicer. (Also it feels redundant to have two items that do nearly the same thing; it took me several months when I first started Code::Blocks to figure out the difference between the two :-[.) If anyone (in this case, it seems it might be you, dmoore) is willing to spend time merging them, I would appreciate it.
dmoore:
--- Quote from: MortenMacFly on September 01, 2012, 12:10:11 am ---
--- Quote from: dmoore on August 30, 2012, 03:10:24 pm ---Here's a separate patch for CodeSnippets [...]
--- End quote ---
For the record: Having applied both patches I see no negative side effect. It seems to work and looks OK.
If you consider to apply, please also remove the obsolete files in SVN and from all build system (projects files, automake).
--- End quote ---
Done. On Linux, I built the full workspace from C::B as well as the configure/make jig. I haven't tested on windows.
I have some plans to rearrange the dialog some more. It is much too tall, but not particularly wide.
dmoore:
Find/Replace Dialog updated in SVN. I think this is a cleaner look and it should work better on smaller screens. Please test and report any issues. Happy to revert this if people don't like it.
Alpha:
--- Quote from: dmoore on September 02, 2012, 06:54:25 am ---Find/Replace Dialog updated in SVN. I think this is a cleaner look and it should work better on smaller screens. Please test and report any issues.
--- End quote ---
It seems to work well so far. If no projects are open, some of the radio boxes should be disabled:
--- Code: ---Index: src/sdk/findreplacedlg.cpp
===================================================================
--- src/sdk/findreplacedlg.cpp (revision 8330)
+++ src/sdk/findreplacedlg.cpp (working copy)
@@ -168,6 +168,18 @@
chTarget->AppendString(active_project->GetBuildTarget(j)->GetTitle());
}
}
+ if (pa->IsEmpty())
+ {
+ if (rbScope->GetSelection() == 1 || rbScope->GetSelection() == 2)
+ {
+ rbScope->SetSelection(0);
+ XRCCTRL(*this, "pnSearchPath", wxPanel)->Show();
+ XRCCTRL(*this, "pnSearchPath", wxPanel)->Disable();
+ XRCCTRL(*this, "pnSearchProject", wxPanel)->Hide();
+ }
+ rbScope->Enable(1, false);
+ rbScope->Enable(2, false);
+ }
if (findReplaceInFilesOnly)
{
--- End code ---
The "Find" tab and the "Replace" tab fail to be hidden (tested on Windows) by:
--- Code: --- if (findReplaceInFilesOnly)
{
// NOTE (jens#1#): Do not delete, just hide the page, to avoid asserts in debug-mode
XRCCTRL(*this, "nbReplace", wxNotebook)->SetSelection(1);
(XRCCTRL(*this, "nbReplace", wxNotebook)->GetPage(0))->Hide(); // no active editor, so only replace-in-files
XRCCTRL(*this, "cmbFind2", wxComboBox)->SetFocus();
}
--- End code ---
(I am not sure how to fix this.)
dmoore:
@Alpha: applied the patch and tried resequencing the constructor logic (renaming notebook tabs before hiding them). See if that makes a difference.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version