Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Some UI refactoring/tidy up
dmoore:
Adding to the original list, here are some more paper cuts with Dialogs and default/escape actions:
7. OK/Close is not default, escape does not close the dialog
select target dialog
file properties
project properties
manage plugins
settings environment
settings editor
settings compiler
settings debugger
settings global variables
8. Escape key does not close the dialog
project build options
file print dialog
add todo item dialog
replace prompt (despite setting SetEscapeId in the constructor)
browse tracker settings (from edit menu)
categories & file types
project remove files
9. too large for small screens
all(?) file picker dialogs (e.g. file open, file save as, project add files, ...)
10. broken layout
settings global variables (need to scroll dialog, probably just missing a layout/fit call)
This is on Linux, not sure there are the same problems on windows. Let me know if I have misdiagnosed or miss some issues. The fixes for 7 and 8 may not be straightforward because they may be due to bugs in wxWidgets.
MortenMacFly:
--- Quote from: dmoore on August 28, 2012, 04:04:10 pm ---I had used svn cp to do this, but the svn diff does not show up the need to copy replacedlg.* first.
--- End quote ---
What you need to do is copy these files plain, the svn add them temporarily, then do the modifications and then create the patch.
Both patches presented here do not work for me. Alternatively just provide the two new files as "plain" files here, not included in the patch.
dmoore:
--- Quote from: MortenMacFly on August 29, 2012, 06:23:35 am ---
--- Quote from: dmoore on August 28, 2012, 04:04:10 pm ---I had used svn cp to do this, but the svn diff does not show up the need to copy replacedlg.* first.
--- End quote ---
What you need to do is copy these files plain, the svn add them temporarily, then do the modifications and then create the patch.
Both patches presented here do not work for me. Alternatively just provide the two new files as "plain" files here, not included in the patch.
--- End quote ---
Did you make the copies using the two commands I suggested? (The bigger problem may be because the patch was created on linux and you are trying to apply to windows)
MortenMacFly:
--- Quote from: dmoore on August 29, 2012, 06:26:00 am ---Did you make the copies using the two commands I suggested?
--- End quote ---
Yes, I did - but they were left un-modifed after applying the patch.
MortenMacFly:
--- Quote from: MortenMacFly on August 29, 2012, 06:27:40 am ---Yes, I did - but they were left un-modifed after applying the patch.
--- End quote ---
BTW, in the patch file you see this:
--- src/sdk/findreplacedlg.cpp (revision 8239)
+++ src/sdk/findreplacedlg.cpp (working copy)
...but this will fail, because in revision 8239 there is no such file. That's why I said you need to add them.
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version