Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

haha I'm on a roll tonight

<< < (2/4) > >>

280Z28:
Just finished this one and now I'm going to bed. Good night y'all, I'll talk with the admins tomorrow when we're all awake regarding getting these patches in.

crc not getting updated properly

Michael:

--- Quote from: 280Z28 on December 16, 2005, 06:31:47 am ---Bugs from sourceforge I've fixed tonight:

Find dialog box previous search ordering
Project tree shows unmodified file as modified
prints only first page of a multipage file
Printout prints only first page (duplicate)
Can only print on the default printer
Check for file modifications crashes C::B

Bugs not on sourceforge I've fixed tonight:
* Print dialog always defaulted to print active selection, even when there was no selection. Now defaults to current editor if there is no selection
* Multi-monitor dialog positioning bug (this isn't perfect because there are bugs related to this in the wxWidgets dll itself)

--- End quote ---

Very good job :). Did you sleep in the night :D?

Michael

MortenMacFly:

--- Quote from: 280Z28 on December 16, 2005, 06:31:47 am ---Bugs from sourceforge I've fixed tonight:

--- End quote ---
...could you provide the patch to public within this thread as an attachment? This way other users could already apply the patch to verify it works and (if so) have more C::B fun... :lol:

To announce that you've done good work is nice, but including the patch is nicer... :P

Morten.

280Z28:

--- Quote from: MortenMacFly on December 16, 2005, 02:25:38 pm ---
--- Quote from: 280Z28 on December 16, 2005, 06:31:47 am ---Bugs from sourceforge I've fixed tonight:

--- End quote ---
...could you provide the patch to public within this thread as an attachment? This way other users could already apply the patch to verify it works and (if so) have more C::B fun... :lol:

To announce that you've done good work is nice, but including the patch is nicer... :P

Morten.


--- End quote ---

I like to go one step at a time. Here's why: I made changes in a lot of files. Before I submitted the first file, I looked at side by side diffs of every single one to check my work and by glad with the way it was done. Once it's committed and I do an svn update, I will merge my changes for exactly one more bug back into the source code (well maybe I'll get all the print issues at once, but I'll stay related). At each step, before I make a patch, I really need to look at what I did.

In particular, the Unicode fix might have some errors, so I'm probably going to take an evening (Sunday) to check it. And I'll probably fix TinyXML at the same time to bring back full Unicode support. If I give out the full patch now as a single file, it's likely to come back with a "hey, what happened here?!" Stuff happens... it was late, etc... gotta check my work.

Oh yeah I slept I just woke up :D

tiwag:
is there any patch available for test now ? where are they ? please provide some links.

thanks

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version