Author Topic: svn rev 1534 - global variable expansion broken  (Read 5653 times)

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
svn rev 1534 - global variable expansion broken
« on: December 16, 2005, 09:25:07 pm »
don't use SVN ver 1534 for a build !!!!!!


@thomas
$(#WX.lib)
expands to
-Iib)
 :shock:

instead of
<WX>\lib
as it should be
 :) :) :)

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: svn rev 1534 - global variable expansion broken
« Reply #1 on: December 16, 2005, 09:32:30 pm »
Darn, I have to go out in 10 mins...
Let me compile quickly and look...
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline tiwag

  • Developer
  • Lives here!
  • *****
  • Posts: 1196
  • sailing away ...
    • tiwag.cb
Re: svn rev 1534 - global variable expansion broken
« Reply #2 on: December 16, 2005, 09:35:48 pm »
Darn, I have to go out in 10 mins...
Let me compile quickly and look...

don't hurry, such **** happens ...
(from time to time, not always of course)  8)

EDIT: Censored by Rick :)
« Last Edit: December 16, 2005, 10:20:28 pm by rickg22 »

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: svn rev 1534 - global variable expansion broken
« Reply #3 on: December 16, 2005, 09:41:07 pm »
Hmm I see what you mean now... -Include) -Iib)\gcc_dll\msw -Iib)\gcc_dllNonUnicode\msw

Will fix that as soon as I'm back, maybe 2-3 hours :?
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline rickg22

  • Lives here!
  • ****
  • Posts: 2283
Re: svn rev 1534 - global variable expansion broken
« Reply #4 on: December 16, 2005, 10:26:54 pm »
Don't forget to make a regression test so the last bug you fixed doesn't come back :)

Offline thomas

  • Administrator
  • Lives here!
  • *****
  • Posts: 3979
Re: svn rev 1534 - global variable expansion broken
« Reply #5 on: December 17, 2005, 02:52:13 am »
Ok, I guess I fixed it. Don't ask what I did though... I only exchanged a few lines, added logging, streamlined the regex a bit, and then it worked. Must have been a trifle...

I ran a test project with a dozen different variables in various formats a couple of times and compiled Code::Blocks 1535 with itself without any warnings, so I guess it works :)
"We should forget about small efficiencies, say about 97% of the time: Premature quotation is the root of public humiliation."

Offline 280Z28

  • Regular
  • ***
  • Posts: 397
  • *insert unicode here*
Re: svn rev 1534 - global variable expansion broken
« Reply #6 on: December 17, 2005, 03:05:44 am »
Ok, I guess I fixed it. Don't ask what I did though... I only exchanged a few lines, added logging, streamlined the regex a bit, and then it worked. Must have been a trifle...

I ran a test project with a dozen different variables in various formats a couple of times and compiled Code::Blocks 1535 with itself without any warnings, so I guess it works :)

Working fine here too. I had gone back to 1533 on that one file for a while; this is better. :)
78 280Z, "a few bolt-ons" - [email protected]
99 Trans Am, "Daily Driver" - 525rwhp/475rwtq
 Check out The Sam Zone :cool:

Offline 280Z28

  • Regular
  • ***
  • Posts: 397
  • *insert unicode here*
Re: svn rev 1534 - global variable expansion broken
« Reply #7 on: December 17, 2005, 03:09:55 am »
Is it supposed to apply changes to global variables immediately, or only after a restart?
78 280Z, "a few bolt-ons" - [email protected]
99 Trans Am, "Daily Driver" - 525rwhp/475rwtq
 Check out The Sam Zone :cool: