how to remove those compiler warnings

[oBFusCATed]

Please commit them as separate changes and, also please increase the SDK version number in cbplugin.h and remember to fix all plugins to use the new API.

[ollydbg]

Done in rev 8048 and rev 8049. Thanks for all your guy's suggestions!!!

[ollydbg]

There are still some warnings like:

Code

[ 35.4%] g++.exe -Wall -g -pipe -mthreads -fmessage-length=0 -fexceptions -Winvalid-pch -DHAVE_W32API_H -D__WXMSW__ -DWXUSINGDLL -DcbDEBUG -DCB_PRECOMP -DWX_PRECOMP -DwxUSE_UNICODE  -Woverloaded-virtual -DEXPORT_LIB -DEXPORT_EVENTS -DWXMAKINGDLL_PROPGRID -DwxPG_USE_WXMODULE=0 -DWXMAKINGDLL_SCI    -iquote.objs\include -I.objs\include -I. -IE:\code\cb\wx\wxWidgets-2.8.12\include -IE:\code\cb\wx\wxWidgets-2.8.12\contrib\include -IE:\code\cb\wx\wxWidgets-2.8.12\lib\gcc_dll\mswu -Isdk\wxscintilla\include -Isdk\wxpropgrid\include -Iinclude\tinyxml -Iinclude -Iinclude\tinyxml -Iinclude\scripting\bindings -Iinclude\scripting\include -Iinclude\scripting\sqplus -Iinclude\mozilla_chardet -Isdk\wxpropgrid\include  -c sdk\scripting\bindings\sc_progress.cpp -o .objs\sdk\scripting\bindings\sc_progress.o
E:\code\cb\wx\wxWidgets-2.8.12\include/wx/generic/progdlgg.h:55:17: warning: 'virtual bool wxProgressDialog::Update(int, const wxString&, bool*)' was hidden [-Woverloaded-virtual]
sdk\scripting\bindings\sc_progress.cpp:42:14: warning:   by 'bool ProgressDialog::Update(int, const wxString&)' [-Woverloaded-virtual]
E:\code\cb\wx\wxWidgets-2.8.12\include/wx/generic/progdlgg.h:62:18: warning: 'virtual void wxProgressDialog::Update()' was hidden [-Woverloaded-virtual]
sdk\scripting\bindings\sc_progress.cpp:42:14: warning:   by 'bool ProgressDialog::Update(int, const wxString&)' [-Woverloaded-virtual]

Code

class ProgressDialog : public wxProgressDialog
{
    public:
        ProgressDialog()
            : wxProgressDialog(_("Progress"),
                                _("Please wait while operation is in progress..."),
                                100, 0,
                                wxPD_AUTO_HIDE | wxPD_APP_MODAL | wxPD_CAN_ABORT)
        {
        }

        ~ProgressDialog()
        {
        }

        ProgressDialog& operator=(const ProgressDialog&)
        {
            cbThrow(_T("ProgressDialog copy constructor should never be called!"));
        }

        bool Update(int value, const wxString& newmsg)
        {
            return wxProgressDialog::Update(value, newmsg, 0);
        }
};

and

Code

class WXDLLEXPORT wxProgressDialog : public wxDialog
{
DECLARE_DYNAMIC_CLASS(wxProgressDialog)
public:
   /* Creates and displays dialog, disables event handling for other
       frames or parent frame to avoid recursion problems.
       @param title title for window
       @param message message to display in window
       @param maximum value for status bar, if <= 0, no bar is shown
       @param parent window or NULL
       @param style is the bit mask of wxPD_XXX constants from wx/defs.h
   */
   wxProgressDialog(const wxString &title, wxString const &message,
                    int maximum = 100,
                    wxWindow *parent = NULL,
                    int style = wxPD_APP_MODAL | wxPD_AUTO_HIDE);
   /* Destructor.
       Re-enables event handling for other windows.
   */
   virtual ~wxProgressDialog();

   /* Update the status bar to the new value.
       @param value new value
       @param newmsg if used, new message to display
       @returns true if ABORT button has not been pressed
   */
   virtual bool Update(int value, const wxString& newmsg = wxEmptyString, bool *skip = NULL);

    /* Switches the dialog to use a gauge in indeterminate mode and calls
       wxGauge::Pulse() to show to the user a bit of progress */
    virtual bool Pulse(const wxString& newmsg = wxEmptyString, bool *skip = NULL);

    // Must provide overload to avoid hiding it (and warnings about it)
    virtual void Update() { wxDialog::Update(); }

Any ideas to handle this issue? Thanks.

[jarod42]

Code

class DerivedClass : public BaseClass
{
using BaseClass::hiddenFunction;

// other stuff.
};

should remove the warnings.

but as seeing the code,

Code

ProgressDialog::update

may be removed.

Note also that

Code

ProgressDialog::operator =

should be private without implementation (or with the 'delete' keyword with C++11).

[MortenMacFly]

...be careful here, this is a script binding. Squirrel needs an equality operator exactly as it is setup. So this might look weird, but its a requirement. You better don't change it, but we should comment these workarounds in the code.