Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Fixed annoying FindDlg bugs

<< < (4/4)

takeshimiya:
I know, but I'm talking of supporting cross-compilation without wine.
And about supporting from C::B the following environments: cross-mingw32, cygwin, cross-cygwin, msys.

duncanka:
I've fixed another minor error in the FindDlg code (I think): if you switched to the "Find in Files" tab before typing the text to search for, the dialog did not save the search term in the search history.  I've created a patch, but I can't test it at the moment.  Could someone test whether the patch below (the forum wouldn't let me attach it as a file) works before I submit it to the tracker?


--- Code: (diff) ---Index: finddlg.cpp
===================================================================
--- finddlg.cpp (revision 2173)
+++ finddlg.cpp (working copy)
@@ -128,7 +128,7 @@
 
  // save last searches (up to 10)
     wxComboBox* combo = XRCCTRL(*this, "cmbFind1", wxComboBox);
- if (!m_Complete)
+ if ( IsFindInFiles() )
         combo = XRCCTRL(*this, "cmbFind2", wxComboBox);
     wxArrayString previous;
     for (int i = 0; (i < combo->GetCount()) && (i < 10); ++i)

--- End code ---

Navigation

[0] Message Index

[*] Previous page