Developer forums (C::B DEVELOPMENT STRICTLY!) > Development
Multi-monitor dialog positioning bug [patch]
280Z28:
--- Quote from: thomas on December 15, 2005, 02:10:49 pm ---No objection from my side if it is an option.
What about simple message boxes? Are those consistent with the other dialogs with your modifications?
--- End quote ---
Not sure which ones are simple. I just changed all the ones that call LoadDialog() in their constructor (since that was easy to search for).
I'll make it an option tonight and post a new patch.
mandrav:
OK, I haven't stepped in this discussions since I don't really care about the subject :P (I work on a single monitor setup). So I 'll let you, who have dual monitor setups, resolve this.
But, 280Z28, do *not* post patches here. They are only going to be lost/forgotten. Patches should be submitted to the patch tracker. That's what we have it for. A forum is *not* a project management tool or medium...
280Z28:
--- Quote from: mandrav on December 15, 2005, 02:42:41 pm ---OK, I haven't stepped in this discussions since I don't really care about the subject :P (I work on a single monitor setup). So I 'll let you, who have dual monitor setups, resolve this.
But, 280Z28, do *not* post patches here. They are only going to be lost/forgotten. Patches should be submitted to the patch tracker. That's what we have it for. A forum is *not* a project management tool or medium...
--- End quote ---
Yeah I just saw that in another thread. I didn't realize you were using it. :)
280Z28:
OK I'm ready to make this an option. I need to add the following function to the SDK. Where should I put it, and what class should it be a public member of? I'm thinking Manager.
--- Code: ---static void Manager::PositionUserDialog( wxDialog* dlg )
{
if (user wants dialogs repositioned centered on parent)
{
dlg->CenterOnScreen();
}
}
--- End code ---
thomas:
--- Code: ---template<wxDialog* D>PlaceDialog()
{
if(Manager::Get()->GetConfigManager("app")->Exists("/environment/place_dialogs"))
D->CentreOnScreen();
};
--- End code ---
That way, we don't pollute Manager -- this does not belong in there.
EDIT: Don't blame me if I have a typo in there... it is late, and I am falling asleep... But you get the idea :)
Navigation
[0] Message Index
[#] Next page
[*] Previous page
Go to full version