User forums > General (but related to Code::Blocks)

Ok for trunk ?

<< < (2/3) > >>

xunxun:
I think the patch refers to the link:
http://forums.codeblocks.org/index.php/topic,14942.msg100987.html#msg100987

reckless:
Aye that was the old one i refined several things since then.
Ill make a diff against trunk and post it here.
Or if you prefer a link to the patch ?.

reckless:
Hmm svn diff is buggering a bit about it luckily only on the last file so check if it writes it correctly.

link to patch http://code.google.com/p/realm/downloads/detail?name=cb-mingw64-trunk.diff&can=2&q=

I removed all x86 cpu optimisation switches from the 64bit only version (does not make much sense to optimize for a cpu that cannot run 64 bit code anyway).
Added corei7 optimization switch (supported by gcc-4.6.0 and later).
Changed default make to winmake instead of mingw32-make (actually mingw64 uses gmake but i hope they will adopt this).
Minor bugger i hope someone else can fix. Autodetect cannot find gdb (weird one as it uses the same name as on mingw) easy to fix though just point it to gdb.exe in mingw32/bin or mingw64/bin but better to fix the code.
All else works it seems.

MortenMacFly:

--- Quote from: reckless on April 16, 2012, 08:15:39 pm ---link to patch http://code.google.com/p/realm/downloads/detail?name=cb-mingw64-trunk.diff&can=2&q=

--- End quote ---
Sorry to say that, but this patch is rather useless, too. Most of the changes is white-space stuff, so actually no functional change. There is an option in SVN to ignore white-space changes. You should always turn that on when creating patches or (even simpler) do not do white-space changes.

Edit1: It frightens me to death to see that the MSVC project loader has been touched when implementing support for MinGW?! ??? ??? ???

Edit2: Also, why having two classes (MinGW32, MinGW64), when MinGW32 = MinGW64 + additional params? Thats no good style. You should make the additional parameters become an option and merge the classes.

reckless:
Mostly done this way to not confuse myself to much im no c++ shark but yeah that would have been the cleaner way.
Hmm was not aware of that option in svn ill check it out.
The msvc changes was to allow importing projects from msvc to mingw64 but i may have gone a bit overboard it seems to work though.

Navigation

[0] Message Index

[#] Next page

[*] Previous page