Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

break "filename:line" will not work in the futher gdb

<< < (5/6) > >>

ollydbg:

--- Quote from: oBFusCATed on April 08, 2012, 10:02:31 am ---Please add a line which demonstrates what kind of lines matches the new regex, because I'm not really sure.

--- End quote ---
Here is what gdb7.4-gdb6.8 returned:

--- Code: ---[debug]> break "E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64"
[debug]No source file named E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp.
[debug]Breakpoint 2 ("E:/code/cb/cb_trunk/src/plugins/codecompletion/parser/token.cpp:64) pending.

--- End code ---

Here is gdb cvs(7.5) returned:

--- Code: ---[debug]> break "E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29"
[debug]No source file named E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp.
[debug]Breakpoint 4 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29") pending.

--- End code ---

You see, the gdb cvs has a quote before right-parenthesis, but gdb7.4-gdb6.8 does not.


--- Quote ---Also your patch doesn't change the setting of breakpoints, why?
--- End quote ---
I don't think the old gdb( 7.4-6.8 ) will works under command like

--- Code: ---break "filename":line

--- End code ---
So, I don't change the bp command send from c::b.


--- Quote ---p.s. I guess you wanted to use preserve instead of deserve?

--- End quote ---
Thanks, It should be "preserve". (My English is not quite good :))

oBFusCATed:

--- Quote from: ollydbg on April 08, 2012, 10:54:51 am ---
--- Code: ---[debug]Breakpoint 4 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29") pending.

--- End code ---

--- End quote ---
Put this line in the patch as a comment and commit it.

Also this line: "Breakpoint ([0-9]+)[ \\t]\\(\\\"(.+):([0-9]+)(\"?)\\)[ \\t]pending\\." looks a bit better to me.

ollydbg:

--- Quote from: oBFusCATed on April 08, 2012, 11:06:29 am ---
--- Quote from: ollydbg on April 08, 2012, 10:54:51 am ---
--- Code: ---[debug]Breakpoint 4 ("E:/code/cb/test_code/DebugDLLTest/TestDLL/dllmain.cpp:29") pending.

--- End code ---

--- End quote ---
Put this line in the patch as a comment and commit it.

Also this line:
--- Code: ---"Breakpoint ([0-9]+)[ \\t]\\(\\\"(.+):([0-9]+)(\"?)\\)[ \\t]pending\\."
--- End code ---
looks a bit better to me.

--- End quote ---

OK, I will refine my patch and commit it, thanks fore the review.

ollydbg:
@OBF:
Do you think that all


--- Code: ---\\\"

--- End code ---
should be turned to

--- Code: ---\"

--- End code ---

You can see there is one instance before the position I changed.

oBFusCATed:
I'm not really sure about the number of \ in this. This is a copy paste from the second line in the regex testbed plugin.
The thing I want in there is (\"?), so it is clear that the " is optional.

Navigation

[0] Message Index

[#] Next page

[*] Previous page