Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

wx2.9 compiler version detection disabled in svn rev 5616 by Biplab

(1/1)

Jenna:
@Biplab (cc: other wx2.9 user/devs):
you have disabled the compiler versiondetection in rev 5616.
This breaks the using of precompiled headers, if they are not besides the headers, because C::B uses -I- instead of -iquote to prepend the include-dir, where the pch's are.

Is this still needed ?
It seems to work on linux 64 bit with wx2.9.4 from trunk and on win7 with wx2.9.3 from official download.

If it is still needed, I would like to change the ifdef with this patch:

--- Code: ---@@ -322,7 +322,9 @@ void CompilerMINGW::SetVersionString()
 {
     /*  NOTE (Biplab#9#): There is a critical bug which blocks C::B from starting up.
         So we'll disable version string checking till we fix the bug. */
-    #if !wxCHECK_VERSION(2, 9, 0)
+    #if wxCHECK_VERSION(2, 9, 0)
+    m_VersionString = _T("4.5.0");
+    #else
 //    Manager::Get()->GetLogManager()->DebugLog(_T("Compiler detection for compiler ID: '") + GetID() + _T("' (parent ID= '") + GetParentID() + _T("')"));
 
     wxArrayString output, errors;

--- End code ---
Just a dirty hack, but compilers less than 4.x.x will hopefully not be used very much with wx2.9 builds.

Biplab:
@Jens,

I can do a check and report back.

Biplab:
@Jens,

A quick test shows that the bug I noticed is now fixed. Thus we can safely enable detection code.

Please go ahead and remove that check. :)

Jenna:

--- Quote from: Biplab on March 01, 2012, 03:44:12 pm ---@Jens,

A quick test shows that the bug I noticed is now fixed. Thus we can safely enable detection code.

Please go ahead and remove that check. :)

--- End quote ---

Done in svn r7867.

Many thanks for the quick check!

Navigation

[0] Message Index