Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

gcc4.7 can't build codeblocks

<< < (11/12) > >>

MortenMacFly:

--- Quote from: jens on August 07, 2012, 12:31:35 am ---After many fixes from killerbot to silent warnings on gcc4.7 and a  pm from him, it looks like I found a solution for the "-fpermissive"-desaster:

--- End quote ---
Is this the same you posted in the other thread?

Jenna:

--- Quote from: MortenMacFly on August 07, 2012, 06:33:51 am ---
--- Quote from: jens on August 07, 2012, 12:31:35 am ---After many fixes from killerbot to silent warnings on gcc4.7 and a  pm from him, it looks like I found a solution for the "-fpermissive"-desaster:

--- End quote ---
Is this the same you posted in the other thread?

--- End quote ---
Yes, but this one is for the public to test it.

It works fine here on fedora 64-bit and gcc4.7, but I did not test it on other platforms and with older compilers.
I don't think it can break anything, just want to be sure, before committing it.

killerbot:
see my comment in the other thread

EDIT : which not everyone can see :
duplicating here :

works fine for me too, however I would change one thing to the patch:

you just removed :     m_pDragCursor = false;

Now the member is not init-ed ==>


--- Code: ---    m_pDragCursor = 0;

--- End code ---

Jenna:

--- Quote from: killerbot on August 07, 2012, 07:47:17 am ---you just removed :     m_pDragCursor = false;

Now the member is not init-ed ==>


--- Code: ---    m_pDragCursor = 0;

--- End code ---


--- End quote ---

It was initialised at the end of the constructor anyway (that's why I just removed the wrong initialisation):

--- Code: ---    m_pDragCursor = new wxCursor(wxCURSOR_HAND);

--- End code ---
To be sure it's 0 in case of a not working initialisation, we can preset it to 0.

killerbot:
no you are absolutely correct, no need to set it. I overlooked that line.

And to be really nice : all of them could have been done in the initializer list :-)
But that's another story.

Let's give people time to object to the patch till this evening ?

Navigation

[0] Message Index

[#] Next page

[*] Previous page

Go to full version