Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

Anyone want a patch to remove the defines of WXMAKINGDLL_PROPGRID etc.

(1/1)

stahta01:
I just created an untested patch to remove the defines of WXMAKINGDLL_PROPGRID, WXMAKINGLIB_PROPGRID, and wxPG_USE_WXMODULE from the CB source and build files.

I replaced the WXMAKINGDLL_PROPGRID and WXMAKINGLIB_PROPGRID with the CB define of EXPORT_LIB.

I will post the patch here if anybody wants to test it.

Patched many *.am and *.cbp files and about 4 cpp/h files.

I also patched the sdk.doxy file; but, I am not sure what that file does.

Tim S.

oBFusCATed:
What is the problem/bug solved by the patch?

stahta01:

--- Quote from: oBFusCATed on February 11, 2012, 01:41:45 am ---What is the problem/bug solved by the patch?

--- End quote ---

Several of the Plugin Managers fails to define the WXMAKINGDLL_PROPGRID Macros this causes warning and results in the build NOT using the precompiled headers.

The binary output after this change should be an exact match of what it was before the change.
But, the build speed should be slightly faster and the warning should be reduced.
The main gain is it it easier for new developers to make a Plugin the correct way.
Because they do NOT have to add a single define statement for the PCH to be properly used in respect to the wxPropertyGrid library. Patch created against the propgrid/debugger branch.

Tim S.    

stahta01:
Noticed that someone applied my patch or a related one to SVN.

I removed my attached patch from prior post.

Note: I found a missed spot. The file Cscope.cbp still have the old macros in it.

Tim S.


--- Code: ---Index: src/plugins/contrib/Cscope/Cscope.cbp
===================================================================
--- src/plugins/contrib/Cscope/Cscope.cbp (revision 8095)
+++ src/plugins/contrib/Cscope/Cscope.cbp (working copy)
@@ -37,8 +38,6 @@
  <Add option="-DWXUSINGDLL" />
  <Add option="-DcbDEBUG" />
  <Add option="-DwxUSE_UNICODE" />
- <Add option="-DWXMAKINGDLL_PROPGRID" />
- <Add option="-DwxPG_USE_WXMODULE=0" />
  <Add directory="$(#WX.include)" />
  <Add directory="$(#WX.lib)\gcc_dll$(WX_CFG)\msw$(WX_SUFFIX)" />
  <Add directory="$(#WX)\contrib\include" />

--- End code ---

MortenMacFly:

--- Quote from: stahta01 on July 08, 2012, 08:17:02 am ---Note: I found a missed spot. The file Cscope.cbp still have the old macros in it.

--- End quote ---
Done. Thanks!

Navigation

[0] Message Index