Developer forums (C::B DEVELOPMENT STRICTLY!) > Development

crash on close cbp project (rev 7773)

<< < (6/6)

ollydbg:

--- Quote from: jens on February 09, 2012, 02:22:47 pm ---
--- Quote from: ollydbg on February 09, 2012, 02:11:28 pm ---There are a lot of TestDestroy() in Parserthread.cpp(In IS_ALIVE macro), should they be deleted too?

--- End quote ---
No, because ParserThread is derived from cbThreadedTask, which has an own implementation of TestDestroy() .

--- End quote ---
Thanks for the explanation. I see the cbThreadedTask class use the much similar implementation like you did:


--- Code: ---inline bool cbThreadedTask::TestDestroy() const
{
  return m_abort;
}

inline bool cbThreadedTask::Aborted() const
{
  return m_abort;
}

inline void cbThreadedTask::Abort()
{
  m_abort = true;
}

--- End code ---


--- Quote from: MortenMacFly on February 09, 2012, 02:46:47 pm ---That was a good one, a relict from my trials to remove calling "directly" into the thread from the class browser UI. I had in mind to (and actually did) provide the builder thread with a job queue so that the class browser attaches jobs as needed and once they are done the UI event is fired up again if signalled from the thread. However, this didn't work reliable.

--- End quote ---
This way looks better than the current implementation. :)

Navigation

[0] Message Index

[*] Previous page