User forums > Using Code::Blocks

Some problems with src/associations.cpp and dlgEnvironmentSettings

<< < (2/2)

killerbot:
Before :

       wxString batchbuildargs = Manager::Get()->GetConfigManager(_T("app"))->Read(_T("/batch_build_args"), _T("/na /nd /ns"));

After :
       wxString batchbuildargs = Manager::Get()->GetConfigManager(_T("app"))->Read(_T("/batch_build_args"), DEFAULT_BATCH_BUILD_ARGS);


Maybe that macro should only be in the cpp file ??

Der Meister:
As I mentioned before: If it is only used in that cpp-file it definitely should be there. This would be the best solution.

EDIT:
I just searched for that macro and found it also in "associations.cpp". Thus it should stay in the header and we should choose another solution for that problem.

Anyway, while searching I noticed another thing:
'Find in Files' didn't find the macro when I demanded it to search in the project files - although the file src/environmentsettingsdlg.cpp was open in the editor, too. And: As I demanded it to search using the path below it said, that there are no files to search in. But after adding a searchmask it worked corectly. Shouldn't be an empty searchmask the same as * (that means, apply to all files)?

mandrav:
Just commited the fix.

Der Meister:
Thanks, it should be alright now.

Just one note to the "Find in files" issue:
If the behaviour I described above is desired, than a little change in line 1561 of the file 'sdk/editormanager.cpp' should do the trick.
Before:

--- Code: ---wxArrayString masks = GetArrayFromString(data->searchMask);
--- End code ---
After:

--- Code: ---wxArrayString masks = GetArrayFromString((data->searchMask.empty()) ? "*" : data->searchMask);
--- End code ---

takeshimiya:

--- Quote from: Der Meister on December 09, 2005, 06:53:05 pm ---Shouldn't be an empty searchmask the same as * (that means, apply to all files)?

--- End quote ---

I think so.

Navigation

[0] Message Index

[*] Previous page