Debugger branch: Placement of Windows

[ollydbg]

There is another issue, see the screen shot:

Is it possible to show at least the "OK" button. (move the dialog a little UP)

[ollydbg]

ollydbg: I don't get what is your problem? As far as I know the newly shown windows are not placed by C::B, but by your Explorer.exe.

I mean that when the debugger setting dialog is shown, can you make it centered on the screen?
I just test the compiler setting dialog, it shows centered which looks fine to me.

[oBFusCATed]

ollydbg: you'll have to debug it yourself, because here it works as intended, but I'm running bigger screens than yours (1600x1200 and 1920x1080). The code for compiler settings and debugger settings is pretty much the same. The only difference is that the Compiler settings are created from xrc resource, but debugger settings are created with wxSmith.

Morten: I wouldn't be surprised if the wx guys have messed the API, once again. But I'll be happy if you take some time and try to find the real cause for the problem.

[ollydbg]

ollydbg: you'll have to debug it yourself, because here it works as intended, but I'm running bigger screens than yours (1600x1200 and 1920x1080). The code for compiler settings and debugger settings is pretty much the same. The only difference is that the Compiler settings are created from xrc resource, but debugger settings are created with wxSmith.

I just debug it myself, and please add one line statement to fix this issue.

Code

Center();

In the end of function body, in file: src\debuggersettingsdlg.cpp around line 108.

Code

DebuggerSettingsDlg::DebuggerSettingsDlg(wxWindow* parent) 

[oBFusCATed]

In fact looking at the code of Compiler settings the correct function should be CenterOnParent(). I will add it...

[MortenMacFly]

In fact looking at the code of Compiler settings the correct function should be CenterOnParent(). I will add it...

I believe there is a C::B API (PlaceWindow, IIRC) that should do this gracefully, also on Multi-Monitor systems...

[oBFusCATed]

Yes, I know and I use it, but it seems that it doesn't work.

[Jenna]

It seems to work here (debian 64bit) with wx 2.8.12 .

[oBFusCATed]

PlaceWindow might be broken on Windows, because it uses some win32 api stuff.
Someone should debug it to see what is going on.


@admins: Can you extract the related posts in a separate topic, because they are not related to the debugger:)

[oBFusCATed]

ollydbg: Can you try in a trunk version to remove the CenterToParent call in the Compiler dialog and to see if it places the dialog at the center of the screen?

[ollydbg]

ollydbg: Can you try in a trunk version to remove the CenterToParent call in the Compiler dialog and to see if it places the dialog at the center of the screen?

I just test it by removing "CentreOnParent();" in the line 104 of cb_trunk\src\src\compilersettingsdlg.cpp.
The result is: dialog does NOT show on the center of the parent window.

PS: CentreOnParent() function works OK on my WinXP without any problem. (wx2.8.12)

[Jenna]

ollydbg: Can you try in a trunk version to remove the CenterToParent call in the Compiler dialog and to see if it places the dialog at the center of the screen?

I just test it by removing "CentreOnParent();" in the line 104 of cb_trunk\src\src\compilersettingsdlg.cpp.
The result is: dialog does NOT show on the center of the parent window.

PS: CentreOnParent() function works OK on my WinXP without any problem. (wx2.8.12)

What are your settings in "Settings -> View" for Multimonitor placement ?

[ollydbg]

ollydbg: Can you try in a trunk version to remove the CenterToParent call in the Compiler dialog and to see if it places the dialog at the center of the screen?

I just test it by removing "CentreOnParent();" in the line 104 of cb_trunk\src\src\compilersettingsdlg.cpp.
The result is: dialog does NOT show on the center of the parent window.

PS: CentreOnParent() function works OK on my WinXP without any problem. (wx2.8.12)

What are your settings in "Settings -> View" for Multimonitor placement ?

Unchecked. (I do not have multi monitors, I have never changed this option, so it is by default)

[Jenna]

ollydbg: Can you try in a trunk version to remove the CenterToParent call in the Compiler dialog and to see if it places the dialog at the center of the screen?

I just test it by removing "CentreOnParent();" in the line 104 of cb_trunk\src\src\compilersettingsdlg.cpp.
The result is: dialog does NOT show on the center of the parent window.

PS: CentreOnParent() function works OK on my WinXP without any problem. (wx2.8.12)

What are your settings in "Settings -> View" for Multimonitor placement ?

Unchecked. (I do not have multi monitors, I have never changed this option, so it is by default)

If the Multimonitor placement checkbox  is unchecked and PlaceWindow() is not called with the third parameter set to true (defaults to false), it does nothing.
See sdk/globals.cpp:1017 .

That is obviously not the best way to implement it (or more exactly) the name is misleading).

You can call PlaceWindow with pdlCentre as second and true as third parameter to enforce placing the window (more or less) regardless the settings in "Settings -> View" .

[oBFusCATed]

So, what should we/I do to fix this problem? Use both functions?