Author Topic: compiling error about autorevision because of space missing of contact git cmd  (Read 47 times)

Offline kipade

  • Multiple posting newcomer
  • *
  • Posts: 54
As we known, cb's official repo is svn, and will generate version infomation from local svn repo directory. And, it still provide a method to generating such version form local git repo. But, the code miss a space character when contact a git command at build_tools/autorevision/autorevision.cpp:221:
        if (GetProcessOutput(output, vcsExecutable + " log --grep=\"git-svn-id\" --max-count=1" + workingDir))
here, there should be a space character between "--max-count=1" and workingDir params.
Hope to fix it. Thanks

Offline ollydbg

  • Developer
  • Lives here!
  • *****
  • Posts: 5902
  • OpenCV and Robotics
    • Chinese OpenCV forum moderator
Hi, long time no see.

Yes, I think you are right. Thanks.
If some piece of memory should be reused, turn them to variables (or const variables).
If some piece of operations should be reused, turn them to functions.
If they happened together, then turn them to classes.

Offline kipade

  • Multiple posting newcomer
  • *
  • Posts: 54
Yes, long time no see. LOL.
I still use cb almost every day and plan to make a project wizard in our team as a RAD tool. So, I always keep my local code as fresh as remote svn repo, and because of inconvenience of svn, I have to fork a git repo at github, and fresh it as soon as possible(if all are ok). So, found the issue.
And, I think it's not a good idea that there were some cb projects or workspaces depended on wx version line **_wx30_**, **_wx32_** in cb src directory. I home the official team would plan to improve it too.