User forums > Embedded development

A simple MCS51 project wizard

<< < (2/2)

scarphin:

--- Quote from: oBFusCATed on October 26, 2011, 09:35:48 am ---There is a typo:

--- End quote ---
Sry for the typo, I'll correct it.


--- Quote from: oBFusCATed on October 26, 2011, 09:35:48 am ---And an unrelated change:

--- End quote ---
I didn't mess with the 'matlab' project, I must have done something wrong while creating the patch.


--- Quote from: oBFusCATed on October 26, 2011, 09:35:48 am ---And commented code, which has to be removed/fixed:

--- Code: ---+//  WarningsOn(project, Wizard.GetCompilerID());

--- End code ---

--- End quote ---
Commented code is for a bug in SDCC (I guess). When all warnings are turned on, compilation stops at the assemble phase. So I commented the code to try it with a newer SDCC version (which hasn't come out yet). I don't know what to do with it, it may be removed as currently it's not needed.


--- Quote from: oBFusCATed on October 26, 2011, 09:35:48 am ---Also can you explain why you're changing the common script?

--- End quote ---
I've added the missing entries for SDCC compiler. Is there something I should know about changing it?

Edit: Btw did I make the patch correct with the '.png' files?

oBFusCATed:
The png's are OK, I suppose, I've not tried it. Just looked at it.

What about the Linux stuff?

scarphin:
Sry I forgot to reply to it. SDCC works on linux too so it's a bug u've found. ;) I'll modify it for both platforms but someone needs to check that on linux.

scarphin:
Ok, I've created a new patch.

The typo and the unrelated 'matlab' change occurred because the files I edited belonged to an old svn version. Someone corrected/changed them in the current svn version so my patch tried to revert them back. ;D It's fixed now. Also removed the commented line and made the windows only part cross platform (needs testing on linux though).

Attached with the '.png' files.

Edit: Also submitted to the patch tracker.

Navigation

[0] Message Index

[*] Previous page

Go to full version