User forums > Nightly builds

The 26 June 2011 build (7257) is out.

<< < (3/6) > >>

MortenMacFly:

--- Quote from: ollydbg on June 28, 2011, 05:26:08 am ---You have clear the string before tokenize it.

--- End quote ---
Ooops - that indeed slipped in and was a patch of yours, btw. ;-)

This one should therefore be reverted. However, I can't do it as I don't have SVN access atm.

oBFusCATed:
Give me a diff and I'll revert muahahaha

ollydbg:
here it is:

--- Code: ---Index: token.cpp
===================================================================
--- token.cpp (revision 7257)
+++ token.cpp (working copy)
@@ -1036,6 +1036,7 @@
 
     token->m_DirectAncestors.clear();
     token->m_Ancestors.clear();
+    wxStringTokenizer tkz(token->m_AncestorsString, _T(","));
 
     TRACE(_T("RecalcInheritanceChain() : Token %s, Ancestors %s"), token->m_Name.wx_str(),
           token->m_AncestorsString.wx_str());
@@ -1047,7 +1048,7 @@
         token->m_AncestorsString.Clear();
 //    }
 
-    wxStringTokenizer tkz(token->m_AncestorsString, _T(","));
+
     while (tkz.HasMoreTokens())
     {
         wxString ancestor = tkz.GetNextToken();

--- End code ---
it is too simple. :D.


--- Quote from: MortenMacFly on June 28, 2011, 07:42:10 am ---
--- Quote from: ollydbg on June 28, 2011, 05:26:08 am ---You have clear the string before tokenize it.

--- End quote ---
Ooops - that indeed slipped in and was a patch of yours, btw. ;-)

--- End quote ---
I nearly forgot my patch :D

Agetian:
Good job, thanks for the fix and for all your work on C::B, definitely the most enjoyable C/C++ coding environment for me! :)

- Agetian

Loaden:

--- Quote from: ollydbg on June 28, 2011, 08:37:16 am ---here it is:

--- Code: ---Index: token.cpp
===================================================================
--- token.cpp (revision 7257)
+++ token.cpp (working copy)
@@ -1036,6 +1036,7 @@
 
     token->m_DirectAncestors.clear();
     token->m_Ancestors.clear();
+    wxStringTokenizer tkz(token->m_AncestorsString, _T(","));
 
     TRACE(_T("RecalcInheritanceChain() : Token %s, Ancestors %s"), token->m_Name.wx_str(),
           token->m_AncestorsString.wx_str());
@@ -1047,7 +1048,7 @@
         token->m_AncestorsString.Clear();
 //    }
 
-    wxStringTokenizer tkz(token->m_AncestorsString, _T(","));
+
     while (tkz.HasMoreTokens())
     {
         wxString ancestor = tkz.GetNextToken();

--- End code ---
it is too simple. :D.


--- Quote from: MortenMacFly on June 28, 2011, 07:42:10 am ---
--- Quote from: ollydbg on June 28, 2011, 05:26:08 am ---You have clear the string before tokenize it.

--- End quote ---
Ooops - that indeed slipped in and was a patch of yours, btw. ;-)

--- End quote ---
I nearly forgot my patch :D


--- End quote ---
It seems not the best way.
ollydbg, could you checking you mail?
I have some question need talk to you.

Navigation

[0] Message Index

[#] Next page

[*] Previous page